Skip to content

Fix type errors - #151

Merged
leonardolaiolo merged 8 commits into
masterfrom
fix_type_errors
May 3, 2022
Merged

Fix type errors#151
leonardolaiolo merged 8 commits into
masterfrom
fix_type_errors

Conversation

@mhidas

Copy link
Copy Markdown
Contributor

Fixes#117

@codecov

codecovBot commented Apr 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #151 (7cdd401) into master (f4dca31) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #151 +/- ##
==========================================
+ Coverage 70.44% 70.46% +0.02% 
==========================================
Files 12 12 Lines 1130 1131 +1 Branches 151 152 +1 ==========================================
+ Hits 796 797 +1 
Misses 317 317 Partials 17 17 
Impacted FilesCoverage Δ
...tools/timeseries_products/aggregated_timeseries.py95.15% <100.00%> (-0.15%)⬇️
aodntools/timeseries_products/common.py88.73% <100.00%> (+2.29%)⬆️
aodntools/timeseries_products/hourly_timeseries.py98.17% <100.00%> (-0.05%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4dca31...7cdd401. Read the comment docs.

@mhidas
mhidas marked this pull request as ready for review April 28, 2022 05:20
@mhidas

Copy link
Copy Markdown
ContributorAuthor

@evacougnon@leonardolaiolo I've tagged you both as reviewers, but only really need one. To be discussed with @ggalibert who will have time for this next iteration (or later...)

@leonardolaiolo
leonardolaiolo merged commit 8f02f5f into masterMay 3, 2022
@leonardolaiolo
leonardolaiolo deleted the fix_type_errors branch May 3, 2022 05:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pandas TypeErrors in hourly_timeseries

2 participants

@mhidas@leonardolaiolo