Uh oh!
There was an error while loading. Please reload this page.
Origin/python 311 - #180
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- constraints.txt: Language not supported
Comments suppressed due to low confidence (1)
setup.py:5
- The updated numpy version 'numpy>=2.2.4' appears incorrect, since numpy versions are typically in the 1.x series. Please verify and set an appropriate version constraint.
'numpy>=2.2.4',
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mphemming
marked this pull request as ready for review
April 7, 2025 05:55
mhidas
reviewed
Apr 8, 2025
mhidas
left a comment
Contributor
There was a problem hiding this comment.
👍 Nice work!
This all looks good... but hold off on merging for now...
mhidas
approved these changes
Apr 8, 2025
mhidas
commented
Apr 8, 2025
Contributor
I've created a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated repository to use Python 3.11 and most recent packages, which required some refactoring. The unitttests are passing locally, and I have tested creating aggregated and hourly products, and running the Rottnest Island ncwriter example script.