Skip to content

fix issue 2201: unexpected empty string behavior - #2203

Merged
MuhammadTahaNaveed merged 1 commit into
apache:masterfrom
jrgemignani:issue_2201_empty_string
Aug 13, 2025
Merged

fix issue 2201: unexpected empty string behavior#2203
MuhammadTahaNaveed merged 1 commit into
apache:masterfrom
jrgemignani:issue_2201_empty_string

Conversation

@jrgemignani

Copy link
Copy Markdown
Contributor

This PR fixes the issue of some string functions returning NULL instead of the empty string.

The string functions affected and corrected are -

reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring, and replace.

Added additional regression tests. Corrected previous tests.

modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c

@jrgemignani

Copy link
Copy Markdown
ContributorAuthor

@MuhammadTahaNaveed There appears to be an issue with the JDBC driver test that is unrelated to this PR.

@MuhammadTahaNaveed

Copy link
Copy Markdown
Member

@MuhammadTahaNaveed There appears to be an issue with the JDBC driver test that is unrelated to this PR.

PR #2206 fixes it.

This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
@jrgemignani
jrgemignaniforce-pushed the issue_2201_empty_string branch from 32b4ec8 to 313e2d0CompareAugust 13, 2025 15:08
@MuhammadTahaNaveed
MuhammadTahaNaveed merged commit 2803ffa into apache:masterAug 13, 2025
7 checks passed
jrgemignani added a commit to jrgemignani/age that referenced this pull request Aug 22, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
@jrgemignanijrgemignani mentioned this pull request Aug 22, 2025
MuhammadTahaNaveed pushed a commit that referenced this pull request Aug 22, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
jrgemignani added a commit to jrgemignani/age that referenced this pull request Sep 9, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
@jrgemignanijrgemignani mentioned this pull request Sep 9, 2025
MuhammadTahaNaveed pushed a commit that referenced this pull request Sep 15, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
jrgemignani added a commit to jrgemignani/age that referenced this pull request Oct 15, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
MuhammadTahaNaveed pushed a commit that referenced this pull request Oct 17, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
jrgemignani added a commit to jrgemignani/age that referenced this pull request Oct 17, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
@jrgemignanijrgemignani mentioned this pull request Oct 17, 2025
MuhammadTahaNaveed pushed a commit that referenced this pull request Oct 17, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
jrgemignani added a commit to jrgemignani/age that referenced this pull request Oct 28, 2025
This PR fixes the issue of some string functions returning NULL
instead of the empty string.
The string functions affected and corrected are -
reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.
Added additional regression tests. Corrected previous tests.
modified: regress/expected/expr.out
modified: regress/sql/expr.sql
modified: src/backend/utils/adt/agtype.c
@jrgemignanijrgemignani mentioned this pull request Oct 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

masteroverride-staleTo keep issues/PRs untouched from stale action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jrgemignani@MuhammadTahaNaveed