Uh oh!
There was an error while loading. Please reload this page.
Fix issue #733 - create_complete_graph() terminates the server - #734
Merged
Conversation
- A vertex and an edge cannot have the same label within the same graph, so added a check for that. - insert_simple_vertex() and insert_simple_edge() functions were not checking for the kind of label. Since a vertex cannot be inserted into a label relation of edge and vice versa, this was causing the server termination. Added a check for that. - Added regression tests.
jrgemignani pushed a commit
that referenced
this pull request
Mar 20, 2023
- A vertex and an edge cannot have the same label within the same graph, so added a check for that. - insert_simple_vertex() and insert_simple_edge() functions were not checking for the kind of label. Since a vertex cannot be inserted into a label relation of edge and vice versa, this was causing the server termination. Added a check for that. - Added regression tests.
jrgemignani added a commit
that referenced
this pull request
Mar 24, 2023
- A vertex and an edge cannot have the same label within the same graph, so added a check for that. - insert_simple_vertex() and insert_simple_edge() functions were not checking for the kind of label. Since a vertex cannot be inserted into a label relation of edge and vice versa, this was causing the server termination. Added a check for that. - Added regression tests. Conflicts: src/backend/utils/graph_generation.c src/include/catalog/ag_label.h Co-authored-by: John Gemignani <jrgemignani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vertex and an edge cannot have the same label within the same graph, so added a check for that.
insert_simple_vertex() and insert_simple_edge() functions were not checking for the kind of label. Since a vertex cannot be inserted into a label relation of edge and vice versa, this was causing the server termination. Added a check for that.
Added regression tests.