Skip to content

Fix misspellings in many AGE files - #985

Merged
jrgemignani merged 1 commit into
apache:masterfrom
jsoref:spelling
Jun 27, 2023
Merged

Fix misspellings in many AGE files#985
jrgemignani merged 1 commit into
apache:masterfrom
jsoref:spelling

Conversation

@jsoref

@jsorefjsoref commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/age/actions/runs/5251077113#summary-14208871486

jsoref
jsoref commented Jun 13, 2023
View reviewed changes

@jsorefjsoref left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections automatically suggested by Google Sheets. All fault mine

Comment threadCONTRIBUTING.md
Comment threadREADME.md
Comment threaddrivers/golang/install.sh
Comment threadsrc/backend/executor/cypher_create.c
Comment threadregress/expected/expr.out
Comment threadregress/expected/index.out
Comment threadsrc/backend/parser/cypher_expr.c
Comment threadsrc/backend/utils/adt/age_global_graph.c
/* internal data structures implementation */

/* vertex entry for the vertex_hastable */
/* vertex entry for the vertex_hashtable */

@jsorefjsorefJun 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@muhammadshoaibmuhammadshoaibJun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one need to be checked in source code as well.

@dehowef

dehowef commented Jun 15, 2023

Copy link
Copy Markdown
Member

The changes that affect spellings in actual code and not just comments might have had an issue, but all regression tests passed, and I reviewed all of the changes manually myself. It looks good, but can you squash all the commits down into one commit?

@jsoref

jsoref commented Jun 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@dehowef squashed

@muhammadshoaib

muhammadshoaib commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Looks good to me.

@jrgemignani

jrgemignani commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

@jsoref Please squash your comments to something more descriptive without listing all of the words fixed.

For example, for the commit description, something like "Fix misspellings in many AGE files (#985)"

For example, for the more detailed descriptions, mention what was done (a general description) and why. But, you don't need to list all of the individual changes. Just a good summary.

@jrgemignani

jrgemignani commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

@jsoref@dehowef@muhammadshoaib There are code reviews that need to be resolved.

jsoref added a commit to jsoref/age that referenced this pull request Jun 16, 2023
@jsoref
Fix misspellings in many AGE files (apache#985)
c6d7e0d
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jrgemignani

jrgemignani commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

@jsoref -

For example, for the more detailed descriptions, mention what was done (a general description) and why. But, you don't need to list all of the individual changes. Just a good summary.

image

dehowef
dehowef reviewed Jun 20, 2023
View reviewed changes

@dehowefdehowef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but please change the description of the commit to a brief summary

Comment threadregress/expected/expr.out
@jrgemignani

jrgemignani commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

@jsoref Please see above comments that are still waiting for you.

@jsorefjsoref changed the title SpellingFix misspellings in many AGE filesJun 22, 2023
@jsoref
Fix misspellings in many AGE files
e36057d
Corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling).
The misspellings were reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref

jsoref commented Jun 26, 2023

Copy link
Copy Markdown
ContributorAuthor

@jrgemignani is this good enough?

@jrgemignani
jrgemignani merged commit d3a3bd5 into apache:masterJun 27, 2023
@jsoref
jsoref deleted the spelling branch June 27, 2023 01:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muhammadshoaibmuhammadshoaibmuhammadshoaib left review comments
@dehowefdehowefdehowef left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsoref@dehowef@muhammadshoaib@jrgemignani