Uh oh!
There was an error while loading. Please reload this page.
Fix issue #945 unaliased match clause giving incorrect results in count - #987
Closed
maazzzzz wants to merge 1 commit into
Closed
Fix issue #945 unaliased match clause giving incorrect results in count#987maazzzzz wants to merge 1 commit into
maazzzzz wants to merge 1 commit into
Conversation
MuhammadTahaNaveed
commented
Jul 18, 2023
Member
@jrgemignani can you please review this one. I think this was missed. |
MuhammadTahaNaveed
commented
Jul 18, 2023
Member
@maazzzzz Does it produce correct result for the below query? MATCH () RETURN count(*) |
maazzzzz
commented
Jul 19, 2023
ContributorAuthor
@MuhammadTahaNaveed checked and it doesn't, missed that case when testing. I'll try looking into it if I get the time but if anyone else could look into it, thatd be great. |
This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days. |
MuhammadTahaNaveed
commented
May 11, 2024
Member
Issue addressed by this PR has already been resolved by PR #1288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unaliased match clause would give incorrect results in count because the node wasn't being added to the join tree. Fixed it by adding unaliased match clauses with valid label names to join tree.
resolves#945