Uh oh!
There was an error while loading. Please reload this page.
UX Enhancement: Add button to clear search query from DAG search - #11583
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| $('#search_form').on('reset', function() { | ||
| var query = new URLSearchParams(window.location.search); | ||
| query.delete('search'); |
There was a problem hiding this comment.
Should we remove page no also? I think the user should always be redirected to the first page.
There was a problem hiding this comment.
Ah, yes, good call!
There was a problem hiding this comment.
Instead of deleting the page param, I had to set it to 0. Because the page value is maintained in the session cookie, that value was re-added to to the URL after deletion. By setting to 0, that will update the cookie value as well.
There was a problem hiding this comment.
I take that back… I was confusing the page param with how the search/tags/status params were being handled. Updated to delete the page param completely.
ryanahamilton
commented
Oct 16, 2020
I've got a follow-up to this PR in the works that will apply this same pattern to the tag filter as well: |
Currently there is no easy way to reset the DAGs view (home) after performing a search—leaving users stranded. This update adds a button (X) that only displays when a search query is present. This button removes the search param from the page and refreshes the page (while retaining other url params).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.