Uh oh!
There was an error while loading. Please reload this page.
Add plain format output to cli tables - #14546
Conversation
Uh oh!
There was an error while loading. Please reload this page.
mik-laj
commented
Mar 1, 2021
turbaszek
commented
Mar 2, 2021
But this will require using |
XD-DENG
commented
Mar 2, 2021
I agree it’s a valid concern. The main reason for what I propose this is that as a dumb person I may need to know what’s exactly the a few columns given to me (it’s obvious what the values’ lookings of course, but may be good to be more explicit). a possible solution may be to describe in the doc/help msg what are the columns printed if “plain” output is chosen? |
mik-laj
commented
Mar 2, 2021
We want to add this format for the best compatibility with various word processing tools. I have given AWK as an example, but other people can parse these tables with other tools. For this reason, it seems to me that we should imitate the behavior of other tools. gcloud display headers So I believe that we should also display the header and not create another data representation format. |
XD-DENG
commented
Mar 2, 2021
Thanks @mik-laj for the examples. Makes sense to me. @turbaszek WDYT? |
turbaszek
commented
Mar 2, 2021
Done There are some nasty warning but I think that #14554 is taking care of that |
XD-DENG
commented
Mar 2, 2021
There may be other situations where WARNING may jump out. Shall we use the decorator |
mik-laj
commented
Mar 2, 2021
WDYT? |
turbaszek
commented
Mar 2, 2021
The decorator is already there, I'm afraid that the warning is raised before initialising airflow - but that's something for another PR I think. |
XD-DENG
commented
Mar 2, 2021
I see. Then all good. Thanks |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
closes: #14517
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.