Uh oh!
There was an error while loading. Please reload this page.
FIX: extends typing-extensions to be installed with python 3.8+ #21566 - #21567
Conversation
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
commented
Feb 15, 2022
Why not just add typing_extension as a dependency? |
Uh oh!
There was an error while loading. Please reload this page.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
frankcash
commented
Feb 15, 2022
Looks like the Github Actions are "failed" because one was cancelled? |
potiuk
commented
Feb 15, 2022
Closed/reopened to check if this was a flaky fail. |
potiuk
commented
Feb 15, 2022
It could be that the typing extension actually causes some too long running constraint generation. |
looks like it timed out again. Let me know how I can help resolve this / if I need to change the code |
potiuk
commented
Feb 16, 2022
Yeah. I was afraid it is not "accident". I will have to take a look at that more closely, but I think the problem is that it creates unsolvable conflict with one of the relased providers (we prepare few variants of the constraints and apparently this one gets triggered. What happens under the hood |
frankcash
commented
Feb 16, 2022
Sounds good, thank you so much for your time |
…w into frankcash/literal-patch
frankcash
commented
Feb 22, 2022
frankcash
commented
Feb 23, 2022
Keeps timing out at |
frankcash
commented
Feb 24, 2022
it looks like a lot of other builds are failing at the build images / build ci image {python_version} step.. |
potiuk
commented
Feb 25, 2022
Not all - only those that change "setup.py". This is pip getting into backtracking loop. |
potiuk
commented
Feb 25, 2022
@frankcash -> I would really love if you could upvote and comment here: pypa/pip#10258 (comment). The problem is that we have no way currently to determine what is the root cause of the problem. The problem is that I proposed to add optional timeout on |
Thanks for linking that @potiuk , I will provide a comment on it. |
potiuk
commented
Feb 25, 2022
@frankcash I think I managed to workaround the pip resolver issue with #21824 - please rebase to latest main. |
frankcash
commented
Feb 25, 2022
🤞 |
frankcash
commented
Feb 25, 2022
@potiuk it worked yay |

Uses built in util to handle import of literal until python 3.8 is phased out.Changes
setup.cfgto installtyping-extensionswill all versions of python, not just<3.8closes: #21566
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.