make operator's execution_timeout configurable

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[sagmansercan]

This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg.

• The default value is still None. Users are expected to
  define an integer value to be passed into timedelta object
  to set the timeout in terms of seconds by default, via configuration.
• Added gettimedelta method in configuration to be used in abstractoperator
  to get timedelta or None type object. The method raises exceptions
  for the values that are;
  • not convertible to integer
  • too large to be converted to C int.
• Sample config cases are added into unit tests.

Closes#18578

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

[sagmansercan]

Since it is possible to provide a Noneexecution_timeout, the config format also need to support that.

Thanks for the comment, could you provide more details on your suggestion with an example use case?

The default behavior is already None. One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.

Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also eval does this, but either way both of them do not sound right to me.

[sagmansercan]

Hi @ashb@eladkal@uranusjr@SamWheating

I've addressed all the comments above, could you please review them again?

[Bowrna]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

[sagmansercan]

@sagmansercan you have to fix the failing static check in the black formatting. Please check.

Thank you for warning @Bowrna, seems like it is related to the black version and fixed in #22598

I will try rebasing and see the result after that because it has not resulted from my changes

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!