Bump cattrs version - #25689

Merged
potiuk merged 1 commit into
apache:mainfrom
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged

Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom
tomsej:cattrs-22.1.0

Conversation

@tomsej

@tomsejtomsej commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

related: #24421

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg

boring-cyborgBot commented Aug 12, 2022

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

ashb
ashb reviewed Aug 12, 2022
View reviewed changes

@ashbashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.

Have you checked the changelog of cattrs to see if anything is likely to break for us?

@tomsej

tomsej commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sounds good to me, but haven't checked anything in detail here.

Have you checked the changelog of cattrs to see if anything is likely to break for us?

Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.

Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?

@ashb

ashb commented Aug 12, 2022

Copy link
Copy Markdown
Member

#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1

Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)

@ashb

ashb commented Aug 12, 2022

Copy link
Copy Markdown
Member

Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)

Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷

numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection

The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml

dependencies:
- numpy

to:

dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

Ah noo.... numpy==1.19.4 :...... This is strange.

@tomsej

tomsej commented Aug 12, 2022

Copy link
Copy Markdown
ContributorAuthor

I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

Yeah. Lookiung at it

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)

@tomsej

tomsej commented Aug 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Ohh, thanks a lot! Let me know if I can help...

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

Fix here #25697 - once it gets green and get merged please rebase @tomsej :)

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)

@tomsej

tomsej commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:

ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use

Do I need to rerun the tests? Dziękuję bardzo :)

@potiuk

potiuk commented Aug 12, 2022

Copy link
Copy Markdown
Member

I re-run it :)

@potiuk
potiuk merged commit c0e637a into apache:mainAug 12, 2022
@boring-cyborg

boring-cyborgBot commented Aug 12, 2022

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@tomsej
tomsej deleted the cattrs-22.1.0 branch August 13, 2022 05:16
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 15, 2022
@ephraimbuddyephraimbuddy added this to the Airflow 2.3.4 milestone Aug 16, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej mentioned this pull request Aug 16, 2022
Closed
2 tasks
@potiukpotiuk linked an issue Aug 16, 2022 that may be closed by this pull request
Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0) #24421
Closed
2 tasks
@ephraimbuddyephraimbuddy mentioned this pull request Aug 20, 2022
Closed
53 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees

No one assigned

Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)

4 participants

@tomsej@ashb@potiuk@ephraimbuddy
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Bump cattrs version - #25689
Merged
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Aug 12, 2022
Merged
Bump cattrs version#25689
potiuk merged 1 commit into
apache:mainfrom 
tomsej:cattrs-22.1.0
Conversation
@tomsej
@tomsejtomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

Contributor
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)

Here are some useful points:
  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
ashb
ashb
reviewed
Aug 12, 2022
View reviewed changes
@ashbashb
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward?
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
#56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
@ashb
ashb
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
dependencies:
- numpy 
to:
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"

But I will try to get rid of it completely in parallel anyway
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ah noo.... numpy==1.19.4 :...... This is strange.
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Yeah. Lookiung at it
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
This is a more complex issue - looks like pip resolver started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
@tomsej
tomsej
commented
Aug 12, 2022

Copy link


Copy Markdown

ContributorAuthor
Ohh, thanks a lot! Let me know if I can help...
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Fix here #25697 - once it gets green and get merged please rebase @tomsej :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
@tomsej
tomsej
commented
Aug 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
 ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use
Do I need to rerun the tests? Dziękuję bardzo :)
@potiuk
potiuk
commented
Aug 12, 2022

Copy link


Copy Markdown

Member
I re-run it :)
@potiuk
potiuk
merged commit c0e637a
into
apache:mainAug 12, 2022
@boring-cyborg
boring-cyborgBot
commented
Aug 12, 2022

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request!
@tomsej
tomsej
deleted the

cattrs-22.1.0

branch
August 13, 2022 05:16
@ephraimbuddyephraimbuddy
added
the 
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 15, 2022
@ephraimbuddyephraimbuddy
added this to the Airflow 2.3.4 milestone
Aug 16, 2022
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 16, 2022
@tomsejRadek Tomšej@ephraimbuddy
Bump cattrs version (#25689)
4e4be5a
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com>
(cherry picked from commit c0e637a)
@tomsejtomsej
mentioned this pull request
Aug 16, 2022

Closed

2 tasks
@potiukpotiuk
linked an issue
Aug 16, 2022
that may be
closed
by this pull request


Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)
#24421

Closed

2 tasks
@ephraimbuddyephraimbuddy
mentioned this pull request
Aug 20, 2022

Closed

53 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ashbashbashb left review comments
@potiukpotiukpotiuk approved these changes

Assignees


No one assigned


Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects


None yet


Milestone

Airflow 2.3.4

Development

Successfully merging this pull request may close these issues.

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0)


4 participants

@tomsej@ashb@potiuk@ephraimbuddy