Uh oh!
There was an error while loading. Please reload this page.
Fix SQL split string to include ;-less statements - #25713
Conversation
potiuk
commented
Aug 14, 2022
e77b396 to
2c9c098Compare2c9c098 to
b73e910Compare@kazanzhy@alexott - I chose a little different approach than proposed in #25640 (comment) - after adding unit tests. I generaly filter out all empty statements during the split - that will even allow comment-only statements for example |
Sorry for being offline. I tried to work on #25259 finally. Initially, I took this code from the drill provider where it was like: which is the like current I tested it with different queries and even with comments and I see that I really missed the query like |
Uh oh!
There was an error while loading. Please reload this page.
There was a bug in an incoming change to common-sql provider introduced in apache#23971 where `;-less` statements were removed when "split_statements" flag was used. Since this flag is used by default in Databricks statement, it introduced backwards incompatible change.
b73e910 to
1224477Comparepotiuk
commented
Aug 15, 2022
I think this one should be ready to review :). |
There was a bug in an incoming change to common-sql provider
introduced in #23971 where
;-lessstatements were removedwhen "split_statements" flag was used. Since this flag is used
by default in Databricks statement, it introduced backwards
incompatible change.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.