Uh oh!
There was an error while loading. Please reload this page.
Require dag_id arg for dags list-runs - #26357
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ashb
reviewed
Sep 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
ashb
approved these changes
Sep 14, 2022
ashb
commented
Sep 14, 2022
Member
Looks like you are breaking something else |
This reverts commit ed6ea72.
While it would ideal to transition to a positional arg like was attempted in apache#25978, this unfortunately does result in a breaking change so we cannot do it now. By instead marking the existing arg as required, we maintain backcompat while also providing a helpful error message to the user if they forget it.
jedcunninghamforce-pushed
the
unbreak_backcompat
branch
from
September 14, 2022 14:44
8c59f85 to
d3961d3Comparekaxil
reviewed
Sep 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
kaxil
approved these changes
Sep 14, 2022
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
jedcunningham
commented
Sep 14, 2022
MemberAuthor
Merging as static check failures is already fixed in main. |
jedcunningham added a commit
that referenced
this pull request
Sep 15, 2022
While it would ideal to transition to a positional arg like was attempted in #25978, this unfortunately does result in a breaking change so we cannot do it now. By instead marking the existing arg as required, we maintain backcompat while also providing a helpful error message to the user if they forget it. This reverts commit ed6ea72. (cherry picked from commit f6c579c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it would ideal to transition to a positional arg like was
attempted in #25978, this unfortunately does result in a breaking change
so we cannot do it now.
By instead marking the existing arg as required, we maintain backcompat
while also providing a helpful error message to the user if they forget
it.
(It is possible to get both a flagged and positional arg working, but I didn't like the complexity necessary in the help docs and code to explain precedence etc. If someone feels strongly about supporting a positional arg, I can take another look at it, or we can do it down the road too.)