Skip to content

Revert "Enable individual trigger logging (#27758)" - #29472

Merged
dstandish merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/ci_timeout_testing
Feb 11, 2023
Merged

Revert "Enable individual trigger logging (#27758)"#29472
dstandish merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/ci_timeout_testing

Conversation

@o-nikolas

Copy link
Copy Markdown
Contributor

This reverts commit 1b18a50.

Some part of this commit is causing tests to hang and timeout. It's a large commit with many changes, instead of waiting to figure out what the issue is and patch it, we should revert it so that main is more stable.

Slack thread here


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:CLI provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Feb 11, 2023
@dstandish
dstandish merged commit 60d4bcd into apache:mainFeb 11, 2023
dstandish added a commit to astronomer/airflow that referenced this pull request Feb 12, 2023
@dstandishdstandish mentioned this pull request Feb 12, 2023
dstandish added a commit that referenced this pull request Feb 12, 2023
Restores trigger logging PR #27758 which was reverted (#29472) due to CI problems.
See commit 5e8aed9 for the fix. We just mock _serve_logs so log server isn't started during the test.
This reverts commit 60d4bcd.
@pierrejeambrunpierrejeambrun added this to the Airflow 2.6.0 milestone Feb 27, 2023
@pierrejeambrunpierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:CLIarea:loggingarea:providersarea:Schedulerincluding HA (high availability) schedulerarea:UIRelated to UI/UX. For Frontend Developers.area:webserverWebserver related Issueschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)provider:amazonAWS/Amazon - related issuesprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:googleGoogle (including GCP) related issuesprovider:microsoft-azureAzure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@o-nikolas@dstandish@pierrejeambrun