Uh oh!
There was an error while loading. Please reload this page.
Run separate CI job for latest boto/botocore version when needed - #30144
Merged
potiuk merged 1 commit intoMar 16, 2023
Conversation
potiuk
requested review from
ashb, eladkal, jedcunningham, kaxil and o-nikolas
as code ownersMarch 16, 2023 14:39
potiuk
commented
Mar 16, 2023
MemberAuthor
There was a problem hiding this comment.
This is unrelated - but I found it along the way. Separate PR follows.
o-nikolas
approved these changes
Mar 16, 2023
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
Nice! Not only will this help us catch issues early, but we'll also be able to solve them incrementally. Rather than receiving one large batch of issues after each version bump.
pankajastro
approved these changes
Mar 16, 2023
potiuk
commented
Mar 16, 2023
MemberAuthor
Precisely |
potiuk
commented
Mar 16, 2023
MemberAuthor
This seemed to work from the first run (The failing tests were environmental issues) This is But yeah it seems to work indeed: and: The 3 skipped were the deferrable tests. |
...potiukforce-pushed
the
add-amazon-tests-for-latest-boto-version
branch
from
March 16, 2023 18:57
ebf5428 to
50c026dComparepotiukforce-pushed
the
add-amazon-tests-for-latest-boto-version
branch
from
March 16, 2023 19:21
8f4df3d to
50c026dCompareeladkal
approved these changes
Mar 16, 2023
eladkal
left a comment
Contributor
There was a problem hiding this comment.
That is very nice improvement!
By using aiobotocore, we are pinning botocore and boto to a specific version (in aiobotocore extra of amazon provider). This means that the boto/botocore dependencies will be updated less frequent in main (every 3-4 months instead of every few days). This has the danger, that we will detect errors resulting from the upgrade much later, so we should run our amazon tests and depending tests with the latest boto/botocore (having aibotocore uninstalled). All deferrable tests should skip when aiobotocore is missing so only non-deferrable tests should run in this job.
potiukforce-pushed
the
add-amazon-tests-for-latest-boto-version
branch
from
March 16, 2023 20:31
50c026d to
5ca4c10Compareferruzzi
commented
Mar 16, 2023
Contributor
Clever solution. 👍 |
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Mar 17, 2023
This is follow-up after apache#30127 and apache#30144 about handling async (deferrable) operators for amazon provider. Rather than making aiobotocre directly a devel extra dependency, we create a separate "aiobotocore" extra that allows for greater flexibility on how we handle the aiobotocore support. It allows for two approach: 1) (current) if we decide that by default we keep boto/botocore compatible with aiobotocore in our constraints/image then aiobotocore should be added to devel and it should be included as preselected extra in Dockerfile. This will lead to having aibotocore and compatible boto/botocore in both constraints and the PROD image. 2) (possible) if we decide that we prefer to keep to the latest version of boto/botocore in constraints/image, then we could remove aiobotocore from both constraints and PROD image. We should also in this case swap the "LatestBoto" CI job introduced in apache#30144 to be "WithAiobotocore" job - by installing aiobotocore and downgrading boto/botocore in the job.
potiuk added a commit
that referenced
this pull request
Mar 17, 2023
This is follow-up after #30127 and #30144 about handling async (deferrable) operators for amazon provider. Rather than making aiobotocre directly a devel extra dependency, we create a separate "aiobotocore" extra that allows for greater flexibility on how we handle the aiobotocore support. It allows for two approach: 1) (current) if we decide that by default we keep boto/botocore compatible with aiobotocore in our constraints/image then aiobotocore should be added to devel and it should be included as preselected extra in Dockerfile. This will lead to having aibotocore and compatible boto/botocore in both constraints and the PROD image. 2) (possible) if we decide that we prefer to keep to the latest version of boto/botocore in constraints/image, then we could remove aiobotocore from both constraints and PROD image. We should also in this case swap the "LatestBoto" CI job introduced in #30144 to be "WithAiobotocore" job - by installing aiobotocore and downgrading boto/botocore in the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using aiobotocore, we are pinning botocore and boto to a specific
version (in aiobotocore extra of amazon provider). This means that
the boto/botocore dependencies will be updated less frequent in main
(every 3-4 months instead of every few days). This has the danger,
that we will detect errors resulting from the upgrade much later,
so we should run our amazon tests and depending tests with
the latest boto/botocore (having aibotocore uninstalled).
All deferrable tests should skip when aiobotocore is missing so only
non-deferrable tests should run in this job.
Depends on #30127 (so only last commit should be checked).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.