Skip to content

Add deferrable mode to BatchSensor - #30279

Merged
pankajastro merged 15 commits into
apache:mainfrom
astronomer:batch_sensor
Jun 14, 2023
Merged

Add deferrable mode to BatchSensor#30279
pankajastro merged 15 commits into
apache:mainfrom
astronomer:batch_sensor

Conversation

@phanikumv

@phanikumvphanikumv commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

This PR donates the BatchAsyncSensor from astronomer-providers to Airflow


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@phanikumv
phanikumvforce-pushed the batch_sensor branch 5 times, most recently from e3c6c54 to 06df4a7CompareMarch 31, 2023 14:32
@phanikumv
phanikumvforce-pushed the batch_sensor branch 4 times, most recently from 38bae75 to b074358CompareApril 6, 2023 16:52
@phanikumvphanikumv changed the title Add BatchAsyncSensorAdd deferrable mode to BatchSensorApr 6, 2023
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 27, 2023
@github-actionsgithub-actionsBot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 28, 2023
@phanikumv
phanikumvforce-pushed the batch_sensor branch 4 times, most recently from dbe77f6 to 5cf180eCompareMay 30, 2023 15:43
@phanikumv
phanikumv marked this pull request as ready for review May 30, 2023 15:43
@phanikumv
phanikumv marked this pull request as draft May 30, 2023 15:48
@phanikumv
phanikumv marked this pull request as ready for review May 30, 2023 15:52
@phanikumv
phanikumvforce-pushed the batch_sensor branch 2 times, most recently from e897a44 to 3f672e2CompareJune 5, 2023 10:09
Comment threadairflow/providers/amazon/aws/triggers/batch.py Outdated
Comment threadairflow/providers/amazon/aws/sensors/batch.py Outdated
Comment threadairflow/providers/amazon/aws/hooks/batch_client.py Outdated
@Lee-WLee-W mentioned this pull request Jun 6, 2023
@phanikumv

Copy link
Copy Markdown
ContributorAuthor

Tests/static checks are failing.

this is fixed

@phanikumv
phanikumvforce-pushed the batch_sensor branch 3 times, most recently from 17cb181 to cdb741aCompareJune 8, 2023 13:15
Comment threadairflow/providers/amazon/aws/sensors/batch.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/batch.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/batch.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/batch.py Outdated
Comment threadairflow/providers/amazon/aws/sensors/batch.py Outdated

@pankajastropankajastro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajastro
pankajastro merged commit 688f91b into apache:mainJun 14, 2023
@pankajastro
pankajastro deleted the batch_sensor branch June 14, 2023 02:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@phanikumv@potiuk@jedcunningham@pankajastro