Skip to content

Remove Python 3.7 support - #30963

Merged
potiuk merged 1 commit into
mainfrom
remove-python-3-7
May 29, 2023
Merged

Remove Python 3.7 support#30963
potiuk merged 1 commit into
mainfrom
remove-python-3-7

Conversation

@potiuk

Copy link
Copy Markdown
Member

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
potiukforce-pushed the remove-python-3-7 branch 8 times, most recently from 52eb8a0 to f3e1370CompareMay 6, 2023 10:18
@potiuk
potiukforce-pushed the remove-python-3-7 branch from f3e1370 to 5025551CompareMay 8, 2023 18:28
@potiuk
potiukforce-pushed the remove-python-3-7 branch 5 times, most recently from 3b7755b to d2b630aCompareMay 16, 2023 21:51
@potiuk
potiukforce-pushed the remove-python-3-7 branch 6 times, most recently from fb34582 to fa520f7CompareMay 21, 2023 19:35
@potiuk
potiukforce-pushed the remove-python-3-7 branch 2 times, most recently from e0a3415 to 504b6d1CompareMay 25, 2023 00:21
Comment threadCI.rst Outdated
Comment threadairflow/providers/alibaba/cloud/log/oss_task_handler.py
@potiuk
potiukforce-pushed the remove-python-3-7 branch 2 times, most recently from 5fcec82 to 8a0d637CompareMay 29, 2023 01:16
@potiuk
potiuk marked this pull request as ready for review May 29, 2023 01:17
@potiuk

potiuk commented May 29, 2023

Copy link
Copy Markdown
MemberAuthor

Marked as "Ready for review" - should be such and I guess we can merged it soon after @eladkal's lazy consensus.

The doubt was raised whether the providers should be 3.8+ only as well - I believe so, it's the same reason we speed up the removal in CI, so providers should be 3.8+ as well IMHO.

@potiuk
potiukforce-pushed the remove-python-3-7 branch 2 times, most recently from 3234d75 to 2cb0b3bCompareMay 29, 2023 02:02
@eladkal

Copy link
Copy Markdown
Contributor

The doubt was raised whether the providers should be 3.8 only as well - I believe so

They should be 3.8+

@potiuk

Copy link
Copy Markdown
MemberAuthor

So - it's all green, ready to final review and merge :)

@potiuk
potiukforce-pushed the remove-python-3-7 branch from 2cb0b3b to 299f8d0CompareMay 29, 2023 07:19
@potiuk
potiukforce-pushed the remove-python-3-7 branch from 299f8d0 to 5eb2e83CompareMay 29, 2023 07:25
@potiuk
potiuk merged commit 9fa75aa into mainMay 29, 2023
@pankajkoti

Copy link
Copy Markdown
Member

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

@potiuk

Copy link
Copy Markdown
MemberAuthor

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

No need. We are not cherry-picking it to 2.6 (so by default it goes to next major relase). And pinned was really there to make sure the 3.11 PR is not closed automatically by the stalebot (the 3.11 was opened in October and it has long period of waiting for dependencies to catch up, so I wanted to make sure stalebot will not close it. The "pinned" label is specifically for stalebot.

@raphaelauv

Copy link
Copy Markdown
Contributor

README of branch main is no more showing 3.7 as a valide version for 2.6.1

Screenshot from 2023-05-29 12-53-21

Is that voluntary ?

@potiuk

Copy link
Copy Markdown
MemberAuthor

README of branch main is no more showing 3.7 as a valide version for 2.6.1

Screenshot from 2023-05-29 12-53-21

Is that voluntary ?

Nope. mistake.

@potiuk

Copy link
Copy Markdown
MemberAuthor

Fix in #31592

@pierrejeambrunpierrejeambrun added this to the Airflow 2.7.0 milestone May 29, 2023
@pankajkoti

Copy link
Copy Markdown
Member

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

No need. We are not cherry-picking it to 2.6 (so by default it goes to next major relase). And pinned was really there to make sure the 3.11 PR is not closed automatically by the stalebot (the 3.11 was opened in October and it has long period of waiting for dependencies to catch up, so I wanted to make sure stalebot will not close it. The "pinned" label is specifically for stalebot.

Okay, understood, nice. Checked it here now that how we save such PRs from the Stalebot here: https://github.com/apache/airflow/blob/main/.github/workflows/stale.yml#L40

@uranusjr
uranusjr deleted the remove-python-3-7 branch May 29, 2023 12:05
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Jul 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@potiuk@eladkal@pankajkoti@raphaelauv@uranusjr@ephraimbuddy@pierrejeambrun