') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add pre-commit to check that aiobotocore is an optional dependency by potiuk · Pull Request #31023 · apache/airflow · GitHub
Skip to content

Add pre-commit to check that aiobotocore is an optional dependency - #31023

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:check-aibotocore-is-optional
May 4, 2023
Merged

Add pre-commit to check that aiobotocore is an optional dependency#31023
potiuk merged 1 commit into
apache:mainfrom
potiuk:check-aibotocore-is-optional

Conversation

@potiuk

@potiukpotiuk commented May 2, 2023

Copy link
Copy Markdown
Member

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk

potiuk commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

image

@potiukpotiuk mentioned this pull request May 2, 2023
Merged
@potiuk
potiuk requested review from eladkal and o-nikolasMay 2, 2023 18:00
@potiuk

potiuk commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

We do not want to check it manually, we alredy got it accidentally merged once for the last amazon's provider's release And we could have easily repeat the mistake: #31018

@potiuk
potiuk requested a review from ferruzziMay 2, 2023 18:02
pankajkoti
pankajkoti approved these changes May 2, 2023
View reviewed changes
Comment threadscripts/ci/pre_commit/pre_commit_check_aiobotocore_optional.py Outdated
Comment threadscripts/ci/pre_commit/pre_commit_check_aiobotocore_optional.py Outdated
eladkal
eladkal reviewed May 2, 2023
View reviewed changes
Comment thread.pre-commit-config.yaml Outdated
@potiuk
potiukforce-pushed the check-aibotocore-is-optional branch from 33b2199 to 87e8890CompareMay 2, 2023 19:59
ferruzzi
ferruzzi approved these changes May 3, 2023
View reviewed changes

@ferruzziferruzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like that you added all providers, just to protect us against Transfers accidentally including it. 👍

@potiuk
potiukforce-pushed the check-aibotocore-is-optional branch from 87e8890 to b9972abCompareMay 4, 2023 09:52
@potiuk
potiuk merged commit 91e18bf into apache:mainMay 4, 2023
@potiuk
potiuk deleted the check-aibotocore-is-optional branch May 4, 2023 12:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankajkotipankajkotipankajkoti approved these changes
@eladkaleladkaleladkal left review comments
@ferruzziferruzziferruzzi approved these changes
@o-nikolaso-nikolaso-nikolas approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner

Assignees

No one assigned

Labels

area:dev-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@potiuk@ferruzzi@pankajkoti@eladkal@o-nikolas