Skip to content

Active deadline seconds - #31146

Closed
andyfcx wants to merge 6 commits into
apache:mainfrom
andyfcx:active_deadline_seconds
Closed

Active deadline seconds#31146
andyfcx wants to merge 6 commits into
apache:mainfrom
andyfcx:active_deadline_seconds

Conversation

@andyfcx

@andyfcxandyfcx commented May 9, 2023•
edited by uranusjr
Loading

Copy link
Copy Markdown

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels May 9, 2023
@potiuk

potiuk commented May 9, 2023

Copy link
Copy Markdown
Member

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

2 similar comments
@potiuk

potiuk commented May 9, 2023

Copy link
Copy Markdown
Member

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

@potiuk

potiuk commented May 9, 2023

Copy link
Copy Markdown
Member

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

@andyfcx

andyfcx commented May 9, 2023

Copy link
Copy Markdown
Author

@potiuk Sure, I will work on this in a few days

@andyfcx
andyfcx marked this pull request as draft May 9, 2023 15:12
@andyfcx
andyfcxforce-pushed the active_deadline_seconds branch from 7e8c59c to d4b72deCompareJune 6, 2023 07:42
@github-actions

github-actionsBot commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 22, 2023
@amoghrajesh

amoghrajesh commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Hi @andyfcx are you still working on this? If not, I would lead it to completion

@andyfcx

andyfcx commented Aug 14, 2023

Copy link
Copy Markdown
Author

I have been too busy to complete my testing on kubernetes, so it would be great if you can complete it, thanks.

@amoghrajesh

amoghrajesh commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Thank you for the handover, working on it

@amoghrajeshamoghrajesh mentioned this pull request Aug 14, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees

No one assigned

Labels

area:providersprovider:cncf-kubernetesKubernetes (k8s) provider related issuesstaleStale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andyfcx@potiuk@amoghrajesh