Uh oh!
There was an error while loading. Please reload this page.
KPO: Add Typing on Security Context - #31275
Conversation
This commit is to add appropriate k8s typing on KubernetesPodOperator's security_context and container_security_context field.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Although providing a dictionary for these variables is acceptable in most cases, it is not recommended. +1 for changing the types to align with the Kubernetes client types.
Please remember to update the tests and replace the dictionary values with the appropriate objects. For ex:
airflow/tests/providers/cncf/kubernetes/operators/test_pod.py
Lines 214 to 232 in 3193857
hussein-awala
left a comment
There was a problem hiding this comment.
Although providing a dictionary for these variables is acceptable in most cases, it is not recommended. +1 for changing the types to align with the Kubernetes client types.
Please remember to update the tests and replace the dictionary values with the appropriate objects. For ex:
airflow/tests/providers/cncf/kubernetes/operators/test_pod.py
Lines 214 to 232 in 3193857
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
amoghrajesh
commented
Aug 14, 2023
This PR seems to have gone stale. I will lead it to completion. Good find @kbumsik! |
This commit is to add appropriate k8s typing on KubernetesPodOperator's security_context and container_security_context field.