Skip to content

Add deferrable mode to PubsubPullSensor - #31284

Merged
potiuk merged 1 commit into
apache:mainfrom
lwyszomi:pubsub
Jun 14, 2023
Merged

Add deferrable mode to PubsubPullSensor#31284
potiuk merged 1 commit into
apache:mainfrom
lwyszomi:pubsub

Conversation

@bkossakowska

Copy link
Copy Markdown
Contributor

Add deferrable mode to PubsubPullSensor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@phanikumvphanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the PubSubAsyncHook please

@bkossakowska
bkossakowska marked this pull request as draft May 17, 2023 06:14
@bkossakowska
bkossakowska marked this pull request as ready for review May 25, 2023 08:39
@bkossakowska
bkossakowskaforce-pushed the pubsub branch 2 times, most recently from e65ea44 to 1866784CompareJune 1, 2023 08:37
@Lee-WLee-W mentioned this pull request Jun 6, 2023
@bkossakowska
bkossakowskaforce-pushed the pubsub branch 2 times, most recently from dc9956a to ec0c8b4CompareJune 9, 2023 14:35
@bkossakowska

Copy link
Copy Markdown
ContributorAuthor

@phanikumv
tests are added

@bkossakowska

Copy link
Copy Markdown
ContributorAuthor

Hi @phanikumv, @potiuk
thanks for your comments, changes have been added. Is there anything else I can improve?

@phanikumvphanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
potiuk merged commit a81ac70 into apache:mainJun 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bkossakowska@potiuk@phanikumv