Skip to content

Revert "Save scheduler execution time by caching dags (#30704)" - #31413

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:revert-index-add
May 19, 2023
Merged

Revert "Save scheduler execution time by caching dags (#30704)"#31413
potiuk merged 1 commit into
apache:mainfrom
potiuk:revert-index-add

Conversation

@potiuk

@potiukpotiuk commented May 19, 2023

Copy link
Copy Markdown
Member

This reverts commit e065f6a.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
potiuk requested review from XD-DENG, ashb and kaxil as code ownersMay 19, 2023 11:39
@boring-cyborgboring-cyborgBot added the area:Scheduler including HA (high availability) scheduler label May 19, 2023
@potiuk
potiuk requested a review from eladkalMay 19, 2023 11:40
@potiuk

potiuk commented May 19, 2023

Copy link
Copy Markdown
MemberAuthor

We need to revert it for now @AutomationDev85 as the original change breaks MSSQL - you will have to recreate the PR (and we will add `full-tests-needed' flag to test it with mssql

eladkal
eladkal approved these changes May 19, 2023
View reviewed changes

@eladkaleladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe time to start thinking about dropping mssql support as backend?
I don't think it brings the value we thought it would...

@potiuk
potiuk merged commit e6f2117 into apache:mainMay 19, 2023
@potiuk
potiuk deleted the revert-index-add branch May 19, 2023 11:48
@potiuk

potiuk commented May 19, 2023

Copy link
Copy Markdown
MemberAuthor

Maybe time to start thinking about dropping mssql support as backend? I don't think it brings the value we thought it would...

I would very very much like that

@potiuk

potiuk commented May 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

A actualy want to wait for result of the survey (which BTW I thikn it's a good idea to run so that we know the results before the summit @TohnJhomas

@potiuk

potiuk commented May 19, 2023

Copy link
Copy Markdown
MemberAuthor

Not @merobi-hub but @TohnJhomas :)

@merobi-hub

merobi-hub commented May 19, 2023 via email

Copy link
Copy Markdown
Contributor

@potiuk

potiuk commented May 19, 2023

Copy link
Copy Markdown
MemberAuthor

Ahh :) . So that was a subconscious guess :)

potiuk added a commit to potiuk/airflow that referenced this pull request May 19, 2023
@potiuk
Revert "Revert "Save scheduler execution time by caching dags (apache…
978a6f7
…#30704)" (apache#31413)"
This reverts commit e6f2117.
potiuk added a commit that referenced this pull request May 19, 2023
@potiuk
Revert wrong migration revertion and revert the right one (#31429)
903dd8d
* Revert "Revert "Save scheduler execution time by caching dags (#30704)" (#31413)"
This reverts commit e6f2117.
* Revert "Save scheduler execution time by adding new Index idea for dag_run (#30827)"
This reverts commit c63b777.
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 6, 2023
@ephraimbuddyephraimbuddy added this to the Airflow 2.7.0 milestone Jul 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkaleladkaleladkal approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees

No one assigned

Labels

area:Schedulerincluding HA (high availability) schedulerchangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

Airflow 2.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@potiuk@merobi-hub@eladkal@ephraimbuddy