Skip to content

Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657

Merged
o-nikolas merged 5 commits into
apache:mainfrom
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged

Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom
aws-mwaa:syedahsn/deferrable-eks-fargate-profile

Conversation

@syedahsn

@syedahsnsyedahsn commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 1, 2023
@Lee-WLee-W mentioned this pull request Jun 6, 2023
Merged
vandonr-amz
vandonr-amz reviewed Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/eks.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/eks.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/eks.py Outdated
@vandonr-amzvandonr-amz mentioned this pull request Jun 7, 2023
Merged
ferruzzi
ferruzzi reviewed Jun 7, 2023
View reviewed changes

@ferruzziferruzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.

Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/operators/eks.py Outdated
Comment threadairflow/providers/amazon/aws/triggers/eks.py Outdated
Comment threadtests/providers/amazon/aws/triggers/test_eks.py Outdated
@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed the syedahsn/deferrable-eks-fargate-profile branch from fd4df6c to 93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz approved these changes Jun 13, 2023
View reviewed changes

@vandonr-amzvandonr-amz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

o-nikolas
o-nikolas approved these changes Jun 14, 2023
View reviewed changes

@o-nikolaso-nikolas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later

@o-nikolas
o-nikolas merged commit 212a37f into apache:mainJun 14, 2023
@eladkaleladkal mentioned this pull request Jun 20, 2023
Closed
86 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi
+1 more reviewer
@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator by syedahsn · Pull Request #31657 · apache/airflow · GitHub
Skip to content
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator - #31657
Merged
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Jun 14, 2023
Merged
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFargateProfileOperator#31657
o-nikolas merged 5 commits into
apache:mainfrom 
aws-mwaa:syedahsn/deferrable-eks-fargate-profile
Conversation
@syedahsn
@syedahsnsyedahsn
commented
Jun 1, 2023

Copy link


Copy Markdown

Contributor
This PR allows deferrable mode to be used with the EksCreateFargateProfileOperator and the EksDeleteFargateProfileOperator. It also includes unit tests to test the triggers for both of the operators.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added

area:providers

provider:amazon
AWS/Amazon - related issues
labels
Jun 1, 2023
@Lee-WLee-W
mentioned this pull request
Jun 6, 2023
 Merged

vandonr-amz
vandonr-amz
reviewed
Jun 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

@vandonr-amzvandonr-amz
mentioned this pull request
Jun 7, 2023
 Merged

ferruzzi
ferruzzi
reviewed
Jun 7, 2023
View reviewed changes
@ferruzziferruzzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-binding suggestions.
Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/operators/eks.py
Outdated

Comment threadairflow/providers/amazon/aws/triggers/eks.py
Outdated

Comment threadtests/providers/amazon/aws/triggers/test_eks.py
Outdated

@syedahsn
Deferrable mode for EksCreateFargateProfileOperator and EksDeleteFarg…
5208255
…ateProfileOperator
Unit tests for both
@syedahsn
Remove hook caching in Trigger
93dce0d
Raise Error from Trigger rather than a TriggerEvent in case of failure
Other minor fixes
@syedahsn
syedahsnforce-pushed
the
syedahsn/deferrable-eks-fargate-profile
branch
from
fd4df6c to
93dce0dCompareJune 13, 2023 21:49
vandonr-amz
vandonr-amz
approved these changes
Jun 13, 2023
View reviewed changes
@vandonr-amzvandonr-amz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
o-nikolas
o-nikolas
approved these changes
Jun 14, 2023
View reviewed changes
@o-nikolaso-nikolas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browsed the code quickly, and there are some other reviews/approvals. Merging this one, we can always circle back later
@o-nikolas
o-nikolas
merged commit 212a37f
into
apache:mainJun 14, 2023
@eladkaleladkal
mentioned this pull request
Jun 20, 2023

Closed

86 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@eladkaleladkalAwaiting requested review from eladkal
@ferruzziferruzziAwaiting requested review from ferruzzi

+1 more reviewer

@vandonr-amzvandonr-amzvandonr-amz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@syedahsn@ferruzzi@o-nikolas@vandonr-amz