Skip to content

PythonVirtualenvOperator: termination error message in alert - #31747

Merged
potiuk merged 1 commit into
apache:mainfrom
karunpoudel:pythonvenv-termination-error-in-alert
Jun 7, 2023
Merged

PythonVirtualenvOperator: termination error message in alert#31747
potiuk merged 1 commit into
apache:mainfrom
karunpoudel:pythonvenv-termination-error-in-alert

Conversation

@karunpoudel

@karunpoudelkarunpoudel commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

The error alert email from PythonVirtualenvOperator and ExternalPythonOperator only contain exit status code. It doesn't contain error messages similar to PythonOperator. This change adds the error message on these operators too.

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@karunpoudel
karunpoudelforce-pushed the pythonvenv-termination-error-in-alert branch from c5eeb84 to 0818ff7CompareJune 6, 2023 22:28
@karunpoudelkarunpoudel changed the title PythonVirtualenvOperator: termination error log in alertPythonVirtualenvOperator: termination error message in alertJun 6, 2023
@karunpoudel
karunpoudelforce-pushed the pythonvenv-termination-error-in-alert branch from 8172d90 to e5dd3feCompareJune 7, 2023 00:19
@karunpoudel
karunpoudel marked this pull request as ready for review June 7, 2023 00:20
Comment threadairflow/operators/python.py Outdated
@karunpoudel
karunpoudelforce-pushed the pythonvenv-termination-error-in-alert branch 2 times, most recently from d3ff257 to 1e75b69CompareJune 7, 2023 18:29

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@potiuk
potiuk merged commit 51419a7 into apache:mainJun 7, 2023
@eladkaleladkal added this to the Airflow 2.7.0 milestone Jun 8, 2023
@eladkaleladkal added the type:improvement Changelog: Improvements label Jun 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:improvementChangelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@karunpoudel@potiuk@eladkal