Skip to content

Refactor of links in Dataproc - #31895

Merged
potiuk merged 2 commits into
apache:mainfrom
lwyszomi:dataproc_links
Aug 3, 2023
Merged

Refactor of links in Dataproc#31895
potiuk merged 2 commits into
apache:mainfrom
lwyszomi:dataproc_links

Conversation

@bkossakowska

Copy link
Copy Markdown
Contributor

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:providers provider:google Google (including GCP) related issues labels Jun 14, 2023
@bkossakowska
bkossakowska marked this pull request as draft June 14, 2023 10:51
Comment threadairflow/providers/google/cloud/links/dataproc.py Outdated
Comment threadairflow/providers/google/cloud/links/dataproc.py Outdated
@bkossakowska
bkossakowskaforce-pushed the dataproc_links branch 2 times, most recently from f053793 to 40726c8CompareJune 16, 2023 07:48
@bkossakowska
bkossakowska marked this pull request as ready for review June 16, 2023 09:16
@potiuk

Copy link
Copy Markdown
Member

conflicts :(

@eladkal

Copy link
Copy Markdown
Contributor

@bkossakowska can you have the conflicts and rebase the PR?

@bkossakowska

Copy link
Copy Markdown
ContributorAuthor

@bkossakowska can you have the conflicts and rebase the PR?

Hi @eladkal,
PR is rebased

@VladaZakharova

Copy link
Copy Markdown
Contributor

Hi @potiuk !
Can we review changes? Thanks!

@VladaZakharova

Copy link
Copy Markdown
Contributor

Hi @uranusjr ! Could you please recheck this PR? Thanks!

@VladaZakharova

Copy link
Copy Markdown
Contributor

Hi @potiuk@eladkal !
Could you please check the changes? :)

@bkossakowska

Copy link
Copy Markdown
ContributorAuthor

Hi @potiuk,
could you please take a look at the changes? Thanks :)

@potiuk
potiuk merged commit 1ea7ae8 into apache:mainAug 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersprovider:googleGoogle (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bkossakowska@potiuk@eladkal@VladaZakharova@uranusjr