docs(deferring): add type annotation to code examples by Lee-W · Pull Request #32422 · apache/airflow

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

Lee-W · 2023-07-07T09:08:51Z

As discussed in #32355 (comment), I'm thinking of adding some type annotations to the documentation.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

pankajastro

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Lee-W · 2023-07-07T10:35:56Z

we should add the same for exampleDateTimeTrigger too we have 2 serialize and run methods there wdyt?

Sorry, I kinda don't get it. Could you point out where is it?

pankajastro · 2023-07-07T10:56:25Z

Sorry, I kinda don't get it. Could you point out where is it?

sure, type annotation for trigger examples also code block https://github.com/apache/airflow/blob/main/docs/apache-airflow/authoring-and-scheduling/deferring.rst?plain=1#L111-L124

Lee-W · 2023-07-07T11:32:16Z

ah yes, I've changed all the code block into that

phanikumv · 2023-07-07T16:07:27Z

 * Any Operator can defer; no special marking on its class is needed, and it's not limited to Sensors.
 * In order for any changes to a Trigger to be reflected, the *triggerer* needs to be restarted whenever the Trigger is modified.
-* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.::
+* If you want add an operator or sensor that supports both deferrable and non-deferrable modes. It's suggested to add ``deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False)`` to the ``__init__`` method of the operator and use it to decide whether to run the operator in deferrable mode. You'll be able to configure the default value of ``deferrable`` of all the operators and sensors that supports switch between deferrable and non-deferrable mode through ``default_deferrable`` in the ``operator`` section. Here's an example of a sensor that supports both modes.


Here we are talking about both operators and sensors, but giving an example of deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False) only for operators.

As the sensor is a kind of operator as well https://github.com/apache/airflow/blob/main/airflow/sensors/base.py#L82, it seems to me this should be fine. But I'm good with making this change as well. We probably should add default_deferrablehere. Maybe that should be another PR?

Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn

LGTM

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

boring-cyborgBot added the kind:documentation label Jul 7, 2023

Lee-W marked this pull request as ready for review July 7, 2023 09:09

Lee-W requested a review from potiuk as a code owner July 7, 2023 09:09

pankajkoti approved these changes Jul 7, 2023
View reviewed changes

uranusjr reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

pankajastro reviewed Jul 7, 2023
View reviewed changes

phanikumv reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated
Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

Lee-W added 2 commits July 8, 2023 00:03

docs(deferring): add type annotation to code examples
4a76b21

docs(deferring): use code-block syntax for code example
0ceeac9

Lee-W force-pushed the add-type-annotation-to-deferrable-example branch from 4c34d66 to 0ceeac9Compare July 7, 2023 16:04

phanikumv reviewed Jul 7, 2023
View reviewed changes

syedahsn reviewed Jul 7, 2023
View reviewed changes

Comment threaddocs/apache-airflow/authoring-and-scheduling/deferring.rst Outdated

rewording
b3de16b
Co-authored-by: Syed Hussain <103602455+syedahsn@users.noreply.github.com>

syedahsn approved these changes Jul 9, 2023
View reviewed changes

potiuk approved these changes Jul 9, 2023
View reviewed changes

potiuk merged commit 5d8c54e into apache:mainJul 9, 2023

eladkal added this to the Airflow 2.6.4 milestone Jul 9, 2023

eladkal added the type:doc-only Changelog: Doc Only label Jul 9, 2023

eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023

Uh oh!

Conversation

Lee-W commented Jul 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pankajastro left a comment

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Jul 7, 2023

Uh oh!

pankajastro commented Jul 7, 2023

Uh oh!

Lee-W commented Jul 7, 2023

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

syedahsn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

Lee-W commented Jul 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pankajastro left a comment

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Jul 7, 2023

Uh oh!

pankajastro commented Jul 7, 2023

Uh oh!

Lee-W commented Jul 7, 2023

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

syedahsn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

Lee-W commented Jul 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pankajastro left a comment

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Jul 7, 2023

Uh oh!

pankajastro commented Jul 7, 2023

Uh oh!

Lee-W commented Jul 7, 2023

Lee-W commented Jul 7, 2023•
edited
Loading

Lee-W commented Jul 7, 2023•
edited
Loading

Lee-W commented Jul 7, 2023•
edited
Loading

Lee-W commented Jul 7, 2023•
edited
Loading