Skip to content

Bring back hive support for Python 3.11 - #32607

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:test-hive-for-3.11
Aug 24, 2023
Merged

Bring back hive support for Python 3.11#32607
potiuk merged 1 commit into
apache:mainfrom
potiuk:test-hive-for-3.11

Conversation

@potiuk

@potiukpotiuk commented Jul 14, 2023

Copy link
Copy Markdown
Member

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiukpotiuk added the full tests needed We need to run full set of tests for this PR to merge label Jul 14, 2023
@potiukpotiuk closed this Jul 14, 2023
@potiukpotiuk reopened this Jul 14, 2023
@potiuk
potiuk marked this pull request as draft July 14, 2023 15:08
@potiukpotiuk mentioned this pull request Jul 14, 2023
Open
@potiuk

potiuk commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

ah @pankajastro I saw yo ualso looked at this one :)

@mdeshmu

mdeshmu commented Jul 14, 2023

Copy link
Copy Markdown

It should be pyhive[hive_pure_sasl]>=0.7.1.dev0

@potiuk

potiuk commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

It should be pyhive[hive_pure_sasl]>=0.7.1.dev0

Yeah. Seems like we have to combine the two :)

@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from 239abef to 1dbb95cCompareJuly 14, 2023 16:32
@potiuk

potiuk commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

Updated. Also removed the "sasl" direct inclusion. Let's see :)

@pankajastropankajastro mentioned this pull request Jul 14, 2023
Merged
@pankajastro

pankajastro commented Jul 14, 2023

Copy link
Copy Markdown
Member

ah @pankajastro I saw yo ualso looked at this one :)

yeah, actually because apache-hive provider (sasl )only.

@potiukpotiuk changed the title Test 0.7.1dev0 version relased with 3.11 supportBring back hive support for Python 3.11 supportJul 15, 2023
@potiukpotiuk changed the title Bring back hive support for Python 3.11 supportBring back hive support for Python 3.11Jul 15, 2023
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch 2 times, most recently from 6e7cfa3 to 02fa709CompareJuly 15, 2023 09:25
@potiuk

potiuk commented Jul 15, 2023

Copy link
Copy Markdown
MemberAuthor

ok. @mdeshmu - I updated the PR to the state as it should be merged when 0.7.1 final release is made. Let us know when the release happen and we will merge it then.

uranusjr
uranusjr reviewed Jul 15, 2023
View reviewed changes
Comment threadairflow/providers/apache/hive/CHANGELOG.rst Outdated
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch 2 times, most recently from bc28545 to 098c566CompareJuly 20, 2023 18:48
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from 098c566 to f10c301CompareAugust 6, 2023 10:25
@mdeshmu

mdeshmu commented Aug 19, 2023

Copy link
Copy Markdown

PyHive 0.7.0 is released which includes Python 3.11 and SQLAlchemy 2.0 support.

potiuk
potiuk commented Aug 19, 2023
View reviewed changes
Comment threadairflow/providers/apache/hive/provider.yaml Outdated
potiuk
potiuk commented Aug 19, 2023
View reviewed changes
Comment threadgenerated/provider_dependencies.json Outdated
@potiuk
potiuk marked this pull request as ready for review August 19, 2023 06:27
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from ae5ff89 to ded4490CompareAugust 19, 2023 06:27
@potiuk

potiuk commented Aug 19, 2023

Copy link
Copy Markdown
MemberAuthor

Seems that `pyhive 0.7.0 has been released and we can bring back Hive support for Python 3.11 finally

@potiukpotiuk added this to the Airflow 2.7.1 milestone Aug 19, 2023
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from ded4490 to 1f5ea3aCompareAugust 21, 2023 22:09
eladkal
eladkal approved these changes Aug 22, 2023
View reviewed changes

@eladkaleladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
No need for 2.7.1 milestone it will be part of provider release cycle

@eladkaleladkal removed this from the Airflow 2.7.1 milestone Aug 22, 2023
@potiukpotiuk added this to the Airflow 2.7.1 milestone Aug 22, 2023
@potiuk

potiuk commented Aug 22, 2023

Copy link
Copy Markdown
MemberAuthor

We will actually need it in 2.7 branch/when we prepare 2.7.1 release.

We need to sync provider dependencies when we add a new provider (and this will need to be cherry-picked). The thing is that provider_dependencies.json is generated from provider.yaml files and it is used to generate airflow's extras. This is not needed for `airflow' package (because in the generated package, the dependencies are replaced with "apache-airflow-providers-apache-hive" dependency), but it matters for constraints generation. If we do not have "apache.hive" in 2-7 branch for Python 3.11 then Airflow 2.7.1 will not have constraints generated by hive even if the provider package with 3.11 support is released.

This is why I marked it with 2.7.1 - so that it gets cherry-picked there.

@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from 1f5ea3a to 8d61724CompareAugust 23, 2023 19:54
@potiuk@uranusjr
Bring back hive support for Python 3.11
b08dc5e
Update airflow/providers/apache/hive/CHANGELOG.rst
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@potiuk
potiukforce-pushed the test-hive-for-3.11 branch from 8d61724 to b08dc5eCompareAugust 23, 2023 20:20
@potiuk

potiuk commented Aug 24, 2023

Copy link
Copy Markdown
MemberAuthor

Just flakes.

@potiuk
potiuk merged commit 08188f8 into apache:mainAug 24, 2023
@potiuk
potiuk deleted the test-hive-for-3.11 branch August 24, 2023 09:52
@pankajastropankajastro mentioned this pull request Aug 24, 2023
Closed
@eladkaleladkal mentioned this pull request Aug 25, 2023
Closed
63 tasks
ephraimbuddy pushed a commit that referenced this pull request Aug 28, 2023
@potiuk@uranusjr@ephraimbuddy
Bring back hive support for Python 3.11 (#32607)
56ec8d7
Update airflow/providers/apache/hive/CHANGELOG.rst
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 08188f8)
@ephraimbuddyephraimbuddy mentioned this pull request Sep 4, 2023
Closed
97 tasks
@andscoopandscoop mentioned this pull request Dec 6, 2023
Closed
2 tasks
@hussein-awalahussein-awala mentioned this pull request Feb 10, 2024
Merged
@TaragolisTaragolis mentioned this pull request Feb 20, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjruranusjruranusjr approved these changes
@eladkaleladkaleladkal approved these changes

Assignees

No one assigned

Labels

area:providersfull tests neededWe need to run full set of tests for this PR to mergeprovider:apache-hive

Projects

None yet

Milestone

Airflow 2.7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@potiuk@mdeshmu@pankajastro@uranusjr@eladkal