Uh oh!
There was an error while loading. Please reload this page.
[AIRFLOW-2382] Fix wrong description for delimiter - #3270
Closed
sekikn wants to merge 1 commit into
Closed
Conversation
Fix misleading descriptions for the 'delimiter' parameter in S3ListOperator and S3ToGoogleCloudStorageOperator's docstring.
Codecov Report
@@ Coverage Diff @@## master #3270 +/- ##
==========================================
- Coverage 75.78% 75.76% -0.03%
==========================================
Files 197 197 Lines 14699 14699 ==========================================
- Hits 11140 11137 -3 - Misses 3559 3562 +3
Continue to review full report at Codecov.
|
r39132
commented
Apr 27, 2018
Contributor
+1 |
aliceabe pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
Fix misleading descriptions for the 'delimiter' parameter in S3ListOperator and S3ToGoogleCloudStorageOperator's docstring. Closesapache#3270 from sekikn/AIRFLOW-2382
pierrejeambrun added a commit
to astronomer/airflow
that referenced
this pull request
Apr 9, 2026
ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (apache#1613, apache#3270): return types degrade to unknown in generated TypeScript code.
pierrejeambrun added a commit
that referenced
this pull request
Apr 16, 2026
* Add cursor-based pagination to get_task_instances endpoint
- Add cursor-based (keyset) pagination as an alternative to offset-based
pagination on the get_task_instances endpoint. Offset pagination remains
the default and is not deprecated globally.
- Response uses a discriminated union: offset responses include
total_entries, cursor responses include next_cursor and previous_cursor.
- Refactor SortParam to lazily cache column resolution instead of
mutating state in to_orm.
- Move cursor helpers (encode/decode/apply) to dedicated
common/db/cursors.py module.
- Cleanly separate cursor vs offset code paths in the endpoint handler.
* Simplify cursor token and support first page without sentinel
- Remove order_by from cursor token (now just a list of values)
- Support empty string cursor for first page (no fake sentinel needed)
- Drop order_by consistency check between cursor and query param
* Small adjustments
* Adjustments
* Narrow endpoint return types and encode cursor value types
Encode type information directly into cursor tokens as
{"type": ..., "value": ...} objects, removing the fragile
column-based type guessing during deserialization.
Narrow return types for endpoints that only return offset
pagination (patch, clear, batch, mapped) so the OpenAPI spec
and generated UI client reflect the correct types. Only
get_task_instances retains the discriminated union response.
Update UI components to use the narrowed types from the spec.
* Use msgpack for cursor tokens and nested keyset predicate
Switch cursor encoding from typed JSON to msgpack for compactness.
Replace flat OR-of-prefix-equalities with nested and/or keyset
predicate for better composite index range scans. Always use
ascending PK as the final tie-breaker for stable pagination.
* Flatten TaskInstanceCollectionRes
ponse to avoid oneOf codegen issues
Replace the discriminated union (offset | cursor response types) with
a single flat model using optional fields. OpenAPI oneOf + discriminator
is not handled correctly by hey-api/openapi-ts (#1613, #3270): return
types degrade to unknown in generated TypeScript code.
* Fix UI
* Fix CI
* Fix cursor pagination boundary detection and error handling
- Fetch limit+1 rows to accurately detect last page, returning
next_cursor=null when no more results exist
- Return previous_cursor=null on the first page (when no cursor
was provided)
- Use LimitFilter in apply_filters_to_select for the +1 limit
instead of a manual .limit() call
- Raise HTTP 400 on invalid UUID in cursor token instead of
silently passing the invalid value
- Update endpoint docs and add boundary-condition test
* Fix backward cursor based paginationpierrejeambrun added a commit
to astronomer/airflow
that referenced
this pull request
Apr 17, 2026
…4845) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (apache#1613, apache#3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
1 task
pierrejeambrun added a commit
to astronomer/airflow
that referenced
this pull request
Apr 20, 2026
…4845) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (apache#1613, apache#3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
pierrejeambrun added a commit
that referenced
this pull request
Apr 20, 2026
…65405) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (#1613, #3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 23, 2026
…65405) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (#1613, #3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 27, 2026
…65405) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (#1613, #3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
…65405) * Add cursor-based pagination to get_task_instances endpoint - Add cursor-based (keyset) pagination as an alternative to offset-based pagination on the get_task_instances endpoint. Offset pagination remains the default and is not deprecated globally. - Response uses a discriminated union: offset responses include total_entries, cursor responses include next_cursor and previous_cursor. - Refactor SortParam to lazily cache column resolution instead of mutating state in to_orm. - Move cursor helpers (encode/decode/apply) to dedicated common/db/cursors.py module. - Cleanly separate cursor vs offset code paths in the endpoint handler. * Simplify cursor token and support first page without sentinel - Remove order_by from cursor token (now just a list of values) - Support empty string cursor for first page (no fake sentinel needed) - Drop order_by consistency check between cursor and query param * Small adjustments * Adjustments * Narrow endpoint return types and encode cursor value types Encode type information directly into cursor tokens as {"type": ..., "value": ...} objects, removing the fragile column-based type guessing during deserialization. Narrow return types for endpoints that only return offset pagination (patch, clear, batch, mapped) so the OpenAPI spec and generated UI client reflect the correct types. Only get_task_instances retains the discriminated union response. Update UI components to use the narrowed types from the spec. * Use msgpack for cursor tokens and nested keyset predicate Switch cursor encoding from typed JSON to msgpack for compactness. Replace flat OR-of-prefix-equalities with nested and/or keyset predicate for better composite index range scans. Always use ascending PK as the final tie-breaker for stable pagination. * Flatten TaskInstanceCollectionRes ponse to avoid oneOf codegen issues Replace the discriminated union (offset | cursor response types) with a single flat model using optional fields. OpenAPI oneOf + discriminator is not handled correctly by hey-api/openapi-ts (#1613, #3270): return types degrade to unknown in generated TypeScript code. * Fix UI * Fix CI * Fix cursor pagination boundary detection and error handling - Fetch limit+1 rows to accurately detect last page, returning next_cursor=null when no more results exist - Return previous_cursor=null on the first page (when no cursor was provided) - Use LimitFilter in apply_filters_to_select for the +1 limit instead of a manual .limit() call - Raise HTTP 400 on invalid UUID in cursor token instead of silently passing the invalid value - Update endpoint docs and add boundary-condition test * Fix backward cursor based pagination (cherry picked from commit e11c603)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
JIRA
Description
Fix misleading descriptions for the 'delimiter'
parameter in S3ListOperator and
S3ToGoogleCloudStorageOperator's docstring.
Tests
No additional test since it's documentation fix.
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff