Skip to content

Refactor Sqlalchemy queries to 2.0 style (Part 7) - #32883

Merged
phanikumv merged 10 commits into
apache:mainfrom
astronomer:sqla_security
Aug 21, 2023
Merged

Refactor Sqlalchemy queries to 2.0 style (Part 7)#32883
phanikumv merged 10 commits into
apache:mainfrom
astronomer:sqla_security

Conversation

@phanikumv

@phanikumvphanikumv commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

This is a continuation of the effort to refactor the queries to sqlalchemy 2.0

related: #28723

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@phanikumvphanikumv added full tests needed We need to run full set of tests for this PR to merge use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) labels Jul 27, 2023
@phanikumvphanikumv reopened this Jul 27, 2023
uranusjr
uranusjr reviewed Jul 28, 2023
View reviewed changes
Comment threadairflow/models/variable.py Outdated
Comment threadairflow/operators/subdag.py Outdated
Comment threadairflow/utils/scheduler_health.py Outdated
Comment threadairflow/www/security.py Outdated
Comment threadairflow/www/security.py Outdated
@phanikumv
phanikumvforce-pushed the sqla_security branch 3 times, most recently from 231df10 to 53c4b13CompareJuly 31, 2023 11:49
uranusjr
uranusjr reviewed Aug 1, 2023
View reviewed changes
Comment threadairflow/auth/managers/fab/models.py Outdated
Comment threadairflow/operators/subdag.py Outdated
Comment threadairflow/utils/scheduler_health.py Outdated
Comment threadairflow/www/security.py Outdated
Comment threadairflow/www/security.py Outdated
Comment threadairflow/www/security.py Outdated
@phanikumv
phanikumvforce-pushed the sqla_security branch 7 times, most recently from c60f6a8 to 9d4d853CompareAugust 8, 2023 08:31
@phanikumv
phanikumvforce-pushed the sqla_security branch 2 times, most recently from 72817e7 to 7e222c1CompareAugust 10, 2023 04:46
uranusjr
uranusjr reviewed Aug 10, 2023
View reviewed changes
Comment threadairflow/dag_processing/processor.py Outdated
@phanikumv
phanikumvforce-pushed the sqla_security branch 4 times, most recently from 17f2956 to 85a03e1CompareAugust 16, 2023 14:17
@phanikumv
phanikumv marked this pull request as ready for review August 17, 2023 08:03
@phanikumvphanikumv changed the title [WIP]:Refactor Sqlalchemy queries to 2.0 style (Part 7)Refactor Sqlalchemy queries to 2.0 style (Part 7)Aug 17, 2023
hussein-awala
hussein-awala reviewed Aug 18, 2023
View reviewed changes
Comment threadairflow/models/skipmixin.py Outdated
ephraimbuddy
ephraimbuddy approved these changes Aug 21, 2023
View reviewed changes

@ephraimbuddyephraimbuddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but generally LGTM

Comment threadairflow/auth/managers/fab/models/__init__.py Outdated
Comment threadairflow/models/variable.py Outdated
Comment threadairflow/operators/subdag.py Outdated
Comment threadairflow/utils/sqlalchemy.py Outdated
Comment threadairflow/www/security.py Outdated
Comment threadairflow/www/security.py Outdated
Comment threadairflow/www/security.py Outdated
Taragolis
Taragolis reviewed Aug 21, 2023
View reviewed changes
Comment threadairflow/datasets/manager.py Outdated
@phanikumv
phanikumv merged commit 4c4981d into apache:mainAug 21, 2023
@phanikumv
phanikumv deleted the sqla_security branch August 21, 2023 13:34
This was referenced Aug 25, 2023
Closed
Closed
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 2, 2023
@ephraimbuddyephraimbuddy added this to the Airflow 2.8.0 milestone Oct 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjruranusjruranusjr approved these changes
@TaragolisTaragolisTaragolis left review comments
@ephraimbuddyephraimbuddyephraimbuddy approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@jhtimminsjhtimminsAwaiting requested review from jhtimmins
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun
@kaxilkaxilAwaiting requested review from kaxil
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@ashbashbAwaiting requested review from ashb
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:dev-toolsarea:providersarea:webserverWebserver related Issuesfull tests neededWe need to run full set of tests for this PR to mergeprovider:celerytype:misc/internalChangelog: Misc changes that should appear in change loguse public runnersMakes sure that Public runners are used even if commiters creates the PR (useful for testing)

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@phanikumv@uranusjr@Taragolis@ephraimbuddy@hussein-awala