Uh oh!
There was an error while loading. Please reload this page.
Fix link_names parameter not being passed to hook in SlackWebhookOperator - #32919
Fix link_names parameter not being passed to hook in SlackWebhookOperator#32919kojiromike wants to merge 1 commit into
link_names parameter not being passed to hook in SlackWebhookOperator#32919Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Please check STATIC_CODE_CHECKS doc to fix the failed test
| # Unused Parameters, warn user if not None | ||
| **({"link_names": self.link_names} if self.link_names else {}), |
There was a problem hiding this comment.
could you add a unit test to ensure that the argument is not provided when it's False?
link_names if it is not Falsylink_names parameter not being passed to hook in SlackWebhookOperatorkojiromike
commented
Aug 3, 2023
I have been unable to get Breeze to build successfully so far. I'll keep trying, but it may take some time. If anyone wants to help, it would be appreciated. |
potiuk
commented
Aug 3, 2023
I wonder what errors you had ? |
| # Unused Parameters, warn user if not None | ||
| **({"link_names": self.link_names} if self.link_names else {}), |
There was a problem hiding this comment.
| # Unused Parameters, warn user if not None | |
| **({"link_names": self.link_names} ifself.link_nameselse {}), |
AFAIK I mark this value as not used for about I year, so we could just remove provide it in to the hook.
Taragolis
commented
Aug 31, 2023
@kojiromike |
Only pass link_names if it has a non-Falsy value
Resolve#32917 by ensuring that SlackWebhookOperator only passes
link_namesto SlackWebhookHook if it has a non-Falsy value.