Skip to content

Extend task context logging support for remote logging using GCS - #32970

Merged
pankajkoti merged 1 commit into
apache:mainfrom
astronomer:task-context-log-gcs-logging
Nov 17, 2023
Merged

Extend task context logging support for remote logging using GCS#32970
pankajkoti merged 1 commit into
apache:mainfrom
astronomer:task-context-log-gcs-logging

Conversation

@pankajkoti

@pankajkotipankajkoti commented Jul 31, 2023

Copy link
Copy Markdown
Member

With the addition of task context logging feature in PR #32646,
this PR extends the feature to GCP Cloud storage when is it set
as remote logging store. Here, backward compatibility is ensured
for older versions of Airflow that do not have the feature included
in Airflow Core.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:logging area:providers provider:google Google (including GCP) related issues labels Jul 31, 2023
@pankajkoti
pankajkotiforce-pushed the task-context-log-gcs-logging branch from 36eba6c to 0ab7436CompareJuly 31, 2023 15:05
@pankajkoti

pankajkoti commented Jul 31, 2023

Copy link
Copy Markdown
MemberAuthor

Backward compatibility test by putting this change on top of main branch locally:
Screenshot 2023-07-31 at 8 10 06 PM

Feature testing by putting these changes on the base PR branch which adds the feature in Airflow Core:
Without this change for GCS remote logging when tasks fail in scheduler:
Screenshot 2023-07-31 at 8 10 01 PM

With this change for GCS remote logging when tasks fail in scheduler:
Screenshot 2023-07-31 at 8 12 00 PM

@pankajkotipankajkoti changed the title Extend task context logging support for remote logging using GCP GCSExtend task context logging support for remote logging using GCSJul 31, 2023
@pankajkoti
pankajkotiforce-pushed the task-context-log-gcs-logging branch from 0ab7436 to f894226CompareJuly 31, 2023 16:33
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 15, 2023
@pankajkotipankajkoti reopened this Nov 14, 2023
@github-actionsgithub-actionsBot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 15, 2023
With the addition of taxt context logging feature in PR apache#32646,
this PR extends the feature to GCP Cloud storage when is it set as
remote logging store. Here, backward compatibility is ensured for
older versions of Airflow that do not have the feature included in
Airflow Core.
@pankajkoti
pankajkotiforce-pushed the task-context-log-gcs-logging branch from f894226 to 4af74f0CompareNovember 17, 2023 12:21
@pankajkoti

pankajkoti commented Nov 17, 2023

Copy link
Copy Markdown
MemberAuthor

Run of latest successful testing fetching logs from GCP GCS task failures due to task marked failed by scheduler after being detected as a zombie
Screenshot 2023-11-17 at 7 24 19 PM

@pankajkoti
pankajkoti marked this pull request as ready for review November 17, 2023 13:56
@pankajkoti
pankajkoti merged commit b9f3a53 into apache:mainNov 17, 2023
@pankajkoti
pankajkoti deleted the task-context-log-gcs-logging branch November 17, 2023 14:47
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
@ephraimbuddyephraimbuddy added this to the Airflow 2.8.0 milestone Nov 20, 2023
@pankajkotipankajkoti mentioned this pull request Oct 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:loggingarea:providerschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)provider:googleGoogle (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pankajkoti@potiuk@ephraimbuddy