Uh oh!
There was an error while loading. Please reload this page.
Improve back-reference generation - #33149
Merged
Merged
Conversation
* better command line support with better auto-complete * allows to run back-referance generation for individual provider packages * better typing including using Pathlib everywhere * handling of redirection between providers - when an operator is moved from one provider to the other - instead of generating invalid "stable" link we generate back reference for all versions of the provider.
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
Impressive work overall. Can see a few small nits
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Aug 6, 2023
MemberAuthor
You should be able to re-apply it now to your PR - it should add a bunch of redirections for old google provider versions for the |
eladkal
commented
Aug 8, 2023
Contributor
@potiuk I think something is wrong. Running: Also scan non-provider refs. Example: |
potiuk
commented
Aug 8, 2023
MemberAuthor
This is fine. It will skip all the the things that are not "versions". |
eladkal
commented
Aug 8, 2023
Contributor
but it doesn't.. |
potiuk
commented
Aug 8, 2023
MemberAuthor
Final (hopefully) fix - removing the need of --gen-type and resulting ambiguities in #33207 |
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Aug 8, 2023
This is a better fix for add-back-references breeze command, as the previous fix had a bug and processed more than just providers when providers --gen-type was selected. See apache#33149. This version fixes it in a much more consistent way: * you have to specify what you want to work on as option * you can select few of the provider via auto-complete * you can also select apache-airflow and helm-chart * you can mix and match them if you need All the scripts and references where `--gen-type` was used previously have been updated and documentation was changed to reflect it
ephraimbuddy pushed a commit
that referenced
this pull request
Aug 8, 2023
* better command line support with better auto-complete * allows to run back-referance generation for individual provider packages * better typing including using Pathlib everywhere * handling of redirection between providers - when an operator is moved from one provider to the other - instead of generating invalid "stable" link we generate back reference for all versions of the provider. (cherry picked from commit 14faf19)
potiuk added a commit
that referenced
this pull request
Aug 9, 2023
This is a better fix for add-back-references breeze command, as the previous fix had a bug and processed more than just providers when providers --gen-type was selected. See #33149. This version fixes it in a much more consistent way: * you have to specify what you want to work on as option * you can select few of the provider via auto-complete * you can also select apache-airflow and helm-chart * you can mix and match them if you need All the scripts and references where `--gen-type` was used previously have been updated and documentation was changed to reflect it
ephraimbuddy pushed a commit
that referenced
this pull request
Oct 5, 2023
* better command line support with better auto-complete * allows to run back-referance generation for individual provider packages * better typing including using Pathlib everywhere * handling of redirection between providers - when an operator is moved from one provider to the other - instead of generating invalid "stable" link we generate back reference for all versions of the provider. (cherry picked from commit 14faf19)
ephraimbuddy pushed a commit
that referenced
this pull request
Oct 5, 2023
This is a better fix for add-back-references breeze command, as the previous fix had a bug and processed more than just providers when providers --gen-type was selected. See #33149. This version fixes it in a much more consistent way: * you have to specify what you want to work on as option * you can select few of the provider via auto-complete * you can also select apache-airflow and helm-chart * you can mix and match them if you need All the scripts and references where `--gen-type` was used previously have been updated and documentation was changed to reflect it (cherry picked from commit 8c28454)
99 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.