Skip to content

Refactor: Simplify code in providers/amazon - #33222

Merged
vincbeck merged 1 commit into
apache:mainfrom
eumiro:providers-amazon
Aug 9, 2023
Merged

Refactor: Simplify code in providers/amazon#33222
vincbeck merged 1 commit into
apache:mainfrom
eumiro:providers-amazon

Conversation

@eumiro

Copy link
Copy Markdown
Contributor

No description provided.

@eumiro
eumiroforce-pushed the providers-amazon branch 2 times, most recently from 8c61734 to 8256a1cCompareAugust 8, 2023 19:56
@vincbeck
vincbeck merged commit 83bd60f into apache:mainAug 9, 2023
@eumiro
eumiro deleted the providers-amazon branch August 9, 2023 17:51
@ferruzzi

Copy link
Copy Markdown
Contributor

I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!

@o-nikolas

Copy link
Copy Markdown
Contributor

I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!

@ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!

@potiuk

Copy link
Copy Markdown
Member

@ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!

I did a pass too. Could not see anything odd. FYI @o-nikolas -> this is a series of cleanups that @eumiro is apparently on a quest of - he had one huge PR to improve some of our less-than-ideal code snippets and I asked him to break it into series of smaller PRs focused on "common" areas - this one is the "aws" provider one.

@vincbeck

Copy link
Copy Markdown
Contributor

Sorry If I merged too fast folks, I did not see anything odd and everything made sense to me. I'll be more patient next time :)

ephraimbuddy pushed a commit that referenced this pull request Aug 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eumiro@ferruzzi@o-nikolas@potiuk@vincbeck