Uh oh!
There was an error while loading. Please reload this page.
Add istio test, use curl /quitquitquit to exit sidecar, and some othe… - #33306
Conversation
Uh oh!
There was an error while loading. Please reload this page.
potiuk
left a comment
There was a problem hiding this comment.
LGTM. But I would love someone elses to take a look as well - who knows better the istio/k8s relations.
Owen-CH-Leung
commented
Aug 26, 2023
@potiuk@eladkal Apology - I just tested locally using breeze with a custom Setting up local airflow env to run KPO with istio enabled isn't so straight forward, so I'll document the steps that I've done here for record also. (FYI I'm using the docker-desktop which comes with k8s cluster and kubectl client)
|
potiuk
commented
Aug 26, 2023
OH... Would be nice to get it into breeze k8s command :) |
Previous 2 PR: #31389, #31390
Refactor the KPO to include istio support. Addressing all the feedback given by others such as:
istio-proxyis injectedcurl localhost:15020/quitquitquitto kill the sidecar when istio is enabled, if istio is not enabled it will fallback to using API calldelete_namespaced_podOnFinishAction. Developers can use existing arguments and the operator will check if sidecar is injected, and use different methods to kill the pod depending on whether sidecar is injected or not