Uh oh!
There was an error while loading. Please reload this page.
openlineage: don't run task instance listener in executor - #33366
Merged
Conversation
mobuchowski
marked this pull request as ready for review
August 14, 2023 16:59
kaxil
reviewed
Aug 14, 2023
mobuchowskiforce-pushed
the
openlineage_dont_run_tis_executor
branch
3 times, most recently
from
August 16, 2023 17:02
2b61b1c to
d55bc6dComparemobuchowski
commented
Aug 16, 2023
ContributorAuthor
@kaxil added test. |
mobuchowskiforce-pushed
the
openlineage_dont_run_tis_executor
branch
2 times, most recently
from
August 18, 2023 12:56
12bd1c4 to
4e01995CompareSigned-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowskiforce-pushed
the
openlineage_dont_run_tis_executor
branch
from
August 18, 2023 13:00
4e01995 to
c9de188Compare63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some circumstances - like explicitely pulling from xcom in
PythonOperatorcurrent implementation can stall database access:This solves this by removing concurrency from the process - the OL emission of START event will always happen before execute.
Concurrent execution will stay on the dag run listener, where it's not accessing database.