Uh oh!
There was an error while loading. Please reload this page.
Add sql_hook_params parameter to S3ToSqlOperator - #33427
Merged
Merged
Conversation
ContributorAuthor
@uranusjr This PR retains how |
alexbeggforce-pushed
the
S3ToSql-hook_params
branch
from
August 16, 2023 06:58
2c5f979 to
f4b0838CompareUh oh!
There was an error while loading. Please reload this page.
alexbegg
marked this pull request as draft
August 16, 2023 07:36
sql_hook_params parameter to S3ToSqlOperatoralexbeggforce-pushed
the
S3ToSql-hook_params
branch
from
August 18, 2023 21:57
f4b0838 to
28d191dCompareAdding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook. This uses the same "sql_hook_params" parameter name as already used in `SqlToSlackOperator`.
alexbeggforce-pushed
the
S3ToSql-hook_params
branch
from
August 18, 2023 22:48
28d191d to
dbe29a3Comparealexbegg
marked this pull request as ready for review
August 18, 2023 22:48
alexbegg
commented
Aug 18, 2023
ContributorAuthor
@uranusjr I corrected the test to access the hook using the changed method of getting it from |
ContributorAuthor
Please remove area:core-operators label from this PR as it no longer changes the core operators |
potiuk
approved these changes
Aug 19, 2023
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
sql_hook_paramsparameter toSqlToS3Operator. This will allow you to pass extra config params to the underlying SQL hook.This uses the same "sql_hook_params" parameter name as already used in
SqlToSlackOperator.(This is related to #33425 which adds
sql_hook_paramsto the opposite transfer,SqlToS3Operator)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.