Uh oh!
There was an error while loading. Please reload this page.
Fix updating account url for WasbHook - #33457
Merged
Merged
Conversation
eladkal
approved these changes
Aug 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
There are different ways users supply the hostname(account url) in azure, sometimes the host doesn't have a urlparse.scheme but has urlparse.path e.g name.blob.windows.net and other times, it will just be Azure ID e.g aldhjf9dads. While working on apache#32980, I assumed that if there's no scheme, then the hostname is not valid, that's incorrect since DNS can serve as the host. The fix was to check if we don't have netloc and that urlparse.path does not include a dot and if it does not, use the login/account_name to construct the account_url
ephraimbuddyforce-pushed
the
fix-azure-account-url
branch
from
August 17, 2023 05:52
6e84479 to
5f78b24Comparehussein-awala
approved these changes
Aug 17, 2023
Lee-W
approved these changes
Aug 17, 2023
This was referenced Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are different ways users supply the hostname(account url) in Azure, sometimes the host doesn't have a urlparse.scheme but has urlparse.path e.g. name.blob.windows.net and other times, it will just be Azure ID e.g. aldhjf9dads. While working on #32980, I assumed that if there's no scheme, then the hostname is not valid, that's incorrect since DNS can serve as the host.
The fix was to check if we don't have netloc and that urlparse.path does not include a dot and if it does not, use the login/account_name to construct the account_url
Closes: #33203