Skip to content

Update list_jobs function in DatabricksHook to token-based pagination - #33472

Merged
potiuk merged 13 commits into
apache:mainfrom
oleksiidav:listjobs-token-pagination
Sep 12, 2023
Merged

Update list_jobs function in DatabricksHook to token-based pagination #33472
potiuk merged 13 commits into
apache:mainfrom
oleksiidav:listjobs-token-pagination

Conversation

@oleksiidav

@oleksiidavoleksiidav commented Aug 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Update Airflow to switch from default offset-based pagination (deprecated) to using a page token

@boring-cyborg

boring-cyborgBot commented Aug 17, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

eladkal
eladkal requested changes Aug 17, 2023
View reviewed changes
Comment threadairflow/providers/databricks/hooks/databricks.py Outdated
@eladkal

eladkal commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

What is JOBS-13077 ?

@oleksiidavoleksiidav changed the title [JOBS-13077] Switch ListJobs to token-based paginationSwitch ListJobs to token-based paginationAug 17, 2023
@oleksiidav

oleksiidav commented Aug 17, 2023

Copy link
Copy Markdown
ContributorAuthor

What is JOBS-13077 ?

Tracking ticket from Databricks side, nevermind

@oleksiidav
oleksiidavforce-pushed the listjobs-token-pagination branch from f60fa07 to 16d9232CompareAugust 18, 2023 15:02
alexott
alexott suggested changes Aug 18, 2023
View reviewed changes

@alexottalexott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good - can we add a unit test for token usage?

@oleksiidav

oleksiidav commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Added test @alexott, PTAL!

alexott
alexott approved these changes Aug 21, 2023
View reviewed changes

@alexottalexott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@eladkal WDYT?

@oleksiidav
oleksiidavforce-pushed the listjobs-token-pagination branch from 91d173e to 7ff7fc8CompareAugust 23, 2023 08:17
@oleksiidav

oleksiidav commented Aug 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @eladkal, could you please take another look?

@potiuk

potiuk commented Aug 24, 2023

Copy link
Copy Markdown
Member

LGTM @eladkal ?

eladkal
eladkal reviewed Aug 24, 2023
View reviewed changes
Comment threadairflow/providers/databricks/hooks/databricks.py Outdated
@oleksiidav
oleksiidavforce-pushed the listjobs-token-pagination branch from 2c6add3 to c8c1c0fCompareAugust 25, 2023 14:53
eladkal
eladkal requested changes Aug 27, 2023
View reviewed changes
Comment threadairflow/providers/databricks/hooks/databricks.py Outdated
@oleksiidav
oleksiidavforce-pushed the listjobs-token-pagination branch from 276cdec to fb5fd82CompareAugust 28, 2023 12:44
@oleksiidav

oleksiidav commented Sep 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Heyy @eladkal , I have updated the tests/formatting, can we pls merge?

@eladkaleladkal changed the title Switch ListJobs to token-based paginationUpdate list_jobs function in DatabricksHook to token-based pagination Sep 8, 2023
@eladkal

eladkal commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

@oleksiidav static checks are failing you are missing import of AirflowProviderDeprecationWarning

@potiuk

potiuk commented Sep 11, 2023

Copy link
Copy Markdown
Member

Static check to fix.

@oleksiidav

oleksiidav commented Sep 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks @eladkal@potiuk ! Fixed it now. Did not have access to test/linter workflow to run checks

@potiuk
potiukforce-pushed the listjobs-token-pagination branch from 0dded80 to 85df103CompareSeptember 11, 2023 20:39
@potiuk
potiuk merged commit dfec053 into apache:mainSep 12, 2023
@boring-cyborg

boring-cyborgBot commented Sep 12, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@oleksiidavoleksiidav mentioned this pull request Oct 13, 2023
Merged
@eladkaleladkal mentioned this pull request Oct 13, 2023
Closed
98 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@eladkaleladkaleladkal approved these changes
+1 more reviewer
@alexottalexottalexott approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providersprovider:databricks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oleksiidav@eladkal@potiuk@alexott