Skip to content

Remove deprecated S3ToSnowflake and SnowflakeToSlack operators - #33558

Merged
potiuk merged 2 commits into
apache:mainfrom
Taragolis:snowflake-remove-remove-deprecated-stuff
Aug 21, 2023
Merged

Remove deprecated S3ToSnowflake and SnowflakeToSlack operators#33558
potiuk merged 2 commits into
apache:mainfrom
Taragolis:snowflake-remove-remove-deprecated-stuff

Conversation

@Taragolis

@TaragolisTaragolis commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

During #33557 found that SnowflakeToSlackOperator is a deprecated version of SqlToSlackOperator

In additional I would like to remove S3ToSnowflakeOperator which is deprecated version of more generic CopyFromExternalStageToSnowflakeOperator

Maybe it is also a good idea to remove SnowflakeOperator, which is also deprecated

ToDo:

  • Update documentation if required
  • Add breaking changes

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis
Taragolis requested a review from eladkalAugust 20, 2023 17:24
@Taragolis
Taragolisforce-pushed the snowflake-remove-remove-deprecated-stuff branch from 386fd57 to f8363baCompareAugust 20, 2023 17:25
@Taragolis
Taragolisforce-pushed the snowflake-remove-remove-deprecated-stuff branch from f8363ba to 992a091CompareAugust 20, 2023 18:35
@Taragolis
Taragolisforce-pushed the snowflake-remove-remove-deprecated-stuff branch from 992a091 to f5b498bCompareAugust 20, 2023 19:16
@Taragolis
Taragolis marked this pull request as ready for review August 20, 2023 19:16

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
potiuk merged commit 86423b4 into apache:mainAug 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should somehow find a way to indicate that this capability is still available via other provider (in automated manner)

My thought here is that users who need this capability might not look at Slack docs. I think it can be very nice if we can indicate in the provider about all the capabilities that can be used with this service regardless if their code base is part of this provider or not (simply mention it existed and reference to the right package but in an automated way)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersarea:system-testsprovider:snowflakeIssues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Taragolis@potiuk@eladkal