Skip to content

Refactor: Replace lambdas with comprehensions - #33745

Merged
potiuk merged 1 commit into
apache:mainfrom
eumiro:less-lambda
Aug 30, 2023
Merged

Refactor: Replace lambdas with comprehensions#33745
potiuk merged 1 commit into
apache:mainfrom
eumiro:less-lambda

Conversation

@eumiro

@eumiroeumiro commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@boring-cyborgboring-cyborgBot added area:dev-tools area:logging area:providers area:Scheduler including HA (high availability) scheduler area:system-tests area:webserver Webserver related Issues provider:amazon AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:elasticsearch provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues provider:openlineage AIP-53 provider:oracle provider:slack labels Aug 25, 2023
@eumiroeumiro changed the title Refactor: Use fewer lambdasRefactor: Replace lambdas with comprehensionsAug 26, 2023
uranusjr
uranusjr reviewed Aug 28, 2023
View reviewed changes
Comment threadairflow/jobs/backfill_job_runner.py Outdated

@uranusjruranusjrAug 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to fit in this PR?

@eumiroeumiroAug 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, thanks, removed.

uranusjr
uranusjr reviewed Aug 29, 2023
View reviewed changes
Comment threaddev/breeze/src/airflow_breeze/utils/parallel.py Outdated

@uranusjruranusjrAug 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return [resultforresultinresultsifresult.ready]
return [resultforresultinresultsifresult.ready()]

uranusjr
uranusjr reviewed Aug 29, 2023
View reviewed changes
Comment threaddev/example_dags/update_example_dags_paths.py Outdated
@potiuk

potiuk commented Aug 30, 2023

Copy link
Copy Markdown
Member

You need to make it ready for review @eumiro

@eumiro
eumiro marked this pull request as ready for review August 30, 2023 18:57
@potiuk
potiuk merged commit 9a0f54d into apache:mainAug 30, 2023
@eumiro
eumiro deleted the less-lambda branch September 3, 2023 17:05
@ephraimbuddyephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
@eumiro@ephraimbuddy
Replace lambdas with comprehensions (#33745)
bf07d01
(cherry picked from commit 9a0f54d)
@ephraimbuddyephraimbuddy mentioned this pull request Oct 9, 2023
Closed
99 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@uranusjruranusjruranusjr approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner

Assignees

No one assigned

Labels

area:dev-toolsarea:loggingarea:providersarea:Schedulerincluding HA (high availability) schedulerarea:system-testsarea:webserverWebserver related Issuesprovider:amazonAWS/Amazon - related issuesprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:elasticsearchprovider:googleGoogle (including GCP) related issuesprovider:microsoft-azureAzure-related issuesprovider:openlineageAIP-53provider:oracleprovider:slacktype:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@eumiro@potiuk@uranusjr@ephraimbuddy