Skip to content

E731: replace lambda by a def method in Airflow core - #33758

Merged
potiuk merged 1 commit into
apache:mainfrom
hussein-awala:E731/core
Aug 26, 2023
Merged

E731: replace lambda by a def method in Airflow core#33758
potiuk merged 1 commit into
apache:mainfrom
hussein-awala:E731/core

Conversation

@hussein-awala

Copy link
Copy Markdown
Member

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit debatable, but yeah it's a bit easier to debug this way (though recently debuggers started to allow to set breakpoints inside lambdas as well.

@potiuk
potiuk merged commit a1d4a20 into apache:mainAug 26, 2023
@ephraimbuddyephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLIarea:webserverWebserver related Issuestype:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hussein-awala@potiuk@Lee-W@ephraimbuddy