ECSTaskOperator - Change default behavior for max attempts by SBurwash · Pull Request #33782 · apache/airflow

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash · 2023-08-26T13:30:37Z

Good day!

I'd like to make a small modification to the EcsTaskOperator's default behavior to ensure that the task does not time out after 10 minutes.

Historically, the ECSTaskOperator would by default set its waiters' max_attemps limit to sys.maxsize. However, this was changed to a default of 10 minutes (waiter_max_attemps * waiter_delay) = 100 * 6 = 600s = 10 minutes (see PR where behavior changed).

To amend this, we:

Changed the default value for the waiter_max_attempts for the ECSTaskOperator from 100 to sys.maxsize
Removed legacy line which did not affect operator behavior
Edited tests to reflect changes

Thanks to @vincbeck for the input on the changes.

boring-cyborg · 2023-08-26T13:30:41Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

hussein-awala · 2023-08-26T15:01:55Z

There is already an open PR (#33712) to fix this issue. If you have any comment or suggestion, you can review it.

I close this one.

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

SBurwash added 2 commits August 26, 2023 09:09

Edited default value for maxsize
26df97a

Ammended tests
df8bc94

SBurwash requested review from eladkal and o-nikolas as code owners August 26, 2023 13:30

boring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 26, 2023

hussein-awala closed this Aug 26, 2023

Taragolis added the duplicate Issue that is duplicated label Aug 26, 2023

Uh oh!

Conversation

SBurwash commented Aug 26, 2023

Uh oh!

boring-cyborgBot commented Aug 26, 2023

Uh oh!

hussein-awala commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SBurwash commented Aug 26, 2023

Uh oh!

boring-cyborgBot commented Aug 26, 2023

Uh oh!

hussein-awala commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SBurwash commented Aug 26, 2023

Uh oh!

boring-cyborgBot commented Aug 26, 2023

Uh oh!

hussein-awala commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SBurwash commented Aug 26, 2023

Uh oh!

boring-cyborgBot commented Aug 26, 2023

Uh oh!

hussein-awala commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SBurwash commented Aug 26, 2023

Uh oh!

boring-cyborgBot commented Aug 26, 2023

Uh oh!

hussein-awala commented Aug 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants