Remove generic trigger cancelled error log by pankajkoti · Pull Request #33874 · apache/airflow

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti · 2023-08-29T09:46:18Z

We tried to address #31720 in PR #31757. The issue talked
about adding a trigger cancelled log when trigger times out,
but we also added a generic Trigger canceled log. This log
appears even in successful runs of the triggers when they
finish. This is confusing some users as the log level is Error
and there are sometimes quite a few log lines saying
"Trigger cancelled; message=" with giving no clue as to what is
happening. So, I am removing this generic error log line and
we can later add specific cancel scenarios with detailed
reasons when we implement those.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We tried to address apache#31720 in PR apache#31757. The issue talked about adding a trigger cancelled log when trigger timesout, but we also added a generic Trigger canceled log. This log appears even in successful runs of the triggers when they finish. This is confusing some users as the log level is Error and there are sometimes quite a few log lines saying "Trigger cancelled; err=" with giving no clue as to what is happening. So, I am removing this generic error log line and we can add specific cancel scenarios with detailed reasons when we implement those.

pankajkoti · 2023-08-29T09:49:18Z

Noisy (& confusing) logs as reported by an user.

uranusjr · 2023-08-29T10:01:57Z

We should first have an open issue to track implementing a replacement log message.

potiuk · 2023-08-29T10:03:49Z

Yep.

pankajkoti · 2023-08-29T10:25:58Z

yes, thank you. Created an issue #33877

pankajkoti requested review from XD-DENG, ashb and kaxil as code owners August 29, 2023 09:46

boring-cyborgBot added area:Scheduler including HA (high availability) scheduler area:Triggerer labels Aug 29, 2023

pankajkoti requested review from Lee-W, dstandish, ephraimbuddy, jedcunningham, o-nikolas, phanikumv, potiuk and uranusjr August 29, 2023 09:50

uranusjr approved these changes Aug 29, 2023
View reviewed changes

uranusjr requested review from XD-DENG, ashb and kaxil and removed request for Lee-W, XD-DENG, ashb, dstandish, ephraimbuddy, jedcunningham, kaxil, o-nikolas, phanikumv and potiuk August 29, 2023 10:02

uranusjr requested review from Lee-W and dstandish August 29, 2023 10:03

potiuk approved these changes Aug 29, 2023
View reviewed changes

Lee-W approved these changes Aug 29, 2023
View reviewed changes

pankajkoti mentioned this pull request Aug 29, 2023
Log appropriate trigger cancel reasons #33877
Closed
2 tasks

uranusjr approved these changes Aug 29, 2023
View reviewed changes

potiuk merged commit 39c202f into apache:mainAug 29, 2023

ephraimbuddy deleted the remove-trigger-cancel-error-log branch October 3, 2023 08:37

ephraimbuddy added this to the Airflow 2.8.0 milestone Oct 3, 2023

ephraimbuddy added the type:improvement Changelog: Improvements label Oct 3, 2023