Skip to content

fix(sensors): move trigger initialization from __init___ to execute - #33926

Merged
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:move-trigger-initialization-to-execute
Aug 30, 2023
Merged

fix(sensors): move trigger initialization from __init___ to execute#33926
ephraimbuddy merged 1 commit into
apache:mainfrom
astronomer:move-trigger-initialization-to-execute

Conversation

@Lee-W

Copy link
Copy Markdown
Member

in #33403, we move trigger initialization to init which blocks users from passing template variable

e.g.,

DateTimeSensorAsync(
task_id="task_id",
target_time="{{ prev_start_date_success }}",
)

this DAG will fails due to the change in #33403


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

in apache#33403, we move trigger initialization to __init__
which causes a failure for one uses template variable
@ephraimbuddyephraimbuddy added this to the Airflow 2.7.1 milestone Aug 30, 2023
@ephraimbuddy
ephraimbuddy merged commit eaa6126 into apache:mainAug 30, 2023
@ephraimbuddy
ephraimbuddy deleted the move-trigger-initialization-to-execute branch August 30, 2023 19:32
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 1, 2023
ephraimbuddy pushed a commit that referenced this pull request Sep 1, 2023
…33926)
in #33403, we move trigger initialization to __init__
which causes a failure for one uses template variable
(cherry picked from commit eaa6126)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lee-W@ephraimbuddy