Uh oh!
There was an error while loading. Please reload this page.
Consolidate importing of os.path.* - #34060
Merged
Merged
Conversation
uranusjr
reviewed
Sep 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Sep 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Sep 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Sep 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Sep 4, 2023
Member
There was a problem hiding this comment.
Suggested change
| AIRFLOW_SOURCES_DIR=Path(__file__).resolve().parents[3] | |
| AIRFLOW_SOURCES_DIR=Path(__file__).parents[3].resolve() |
or
Suggested change
| AIRFLOW_SOURCES_DIR=Path(__file__).resolve().parents[3] | |
| AIRFLOW_SOURCES_DIR=Path(__file__).parents[3] |
since the original code seems to work without resolving anyway?
ContributorAuthor
There was a problem hiding this comment.
There are 13 occurrences of resolve().parents in the repo. Should we fix them all?
Member
There was a problem hiding this comment.
That’d be awesome, although we can focus on the lines changed in this PR first.
eumiro
marked this pull request as ready for review
September 4, 2023 08:55
eumiro
requested review from
ashb, bbovenzi, eladkal, jedcunningham, o-nikolas, pierrejeambrun, potiuk and ryanahamilton
as code ownersSeptember 4, 2023 08:55
potiuk
commented
Sep 4, 2023
Member
pending @uranusjr chaanges. |
uranusjr
approved these changes
Sep 6, 2023
ephraimbuddy pushed a commit
that referenced
this pull request
Oct 5, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 9079093)
99 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.