Skip to content

Refactor: Simplify string generation - #34118

Merged
potiuk merged 1 commit into
apache:mainfrom
eumiro:string-generation
Sep 11, 2023
Merged

Refactor: Simplify string generation#34118
potiuk merged 1 commit into
apache:mainfrom
eumiro:string-generation

Conversation

@eumiro

@eumiroeumiro commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

No description provided.

uranusjr
uranusjr reviewed Sep 5, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/sagemaker.py Outdated
uranusjr
uranusjr reviewed Sep 6, 2023
View reviewed changes
Comment threadairflow/providers/microsoft/azure/hooks/wasb.py Outdated
@eumiro
eumiro marked this pull request as ready for review September 6, 2023 17:05
uranusjr
uranusjr reviewed Sep 7, 2023
View reviewed changes
Comment threadairflow/providers/amazon/aws/operators/sagemaker.py Outdated
uranusjr
uranusjr reviewed Sep 7, 2023
View reviewed changes
Comment threadairflow/providers/microsoft/azure/hooks/wasb.py Outdated
Comment threadairflow/providers/microsoft/azure/hooks/wasb.py Outdated
Comment threadscripts/in_container/run_migration_reference.py Outdated
dwreeves
dwreeves reviewed Sep 8, 2023
View reviewed changes
Comment threadairflow/providers/cncf/kubernetes/operators/pod.py Outdated

@dwreevesdwreevesSep 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this is not a refactor as the - is always included in the new version, but not the old version.

@eumiroeumiroSep 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@potiuk
potiuk merged commit a1fe77b into apache:mainSep 11, 2023
@eumiro
eumiro deleted the string-generation branch September 11, 2023 17:53
@ephraimbuddyephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
@eumiro@ephraimbuddy
Refactor: Simplify string generation (#34118)
3188f51
(cherry picked from commit a1fe77b)
@ephraimbuddyephraimbuddy mentioned this pull request Oct 9, 2023
Closed
99 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@uranusjruranusjruranusjr approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@dstandishdstandishAwaiting requested review from dstandish
+1 more reviewer
@dwreevesdwreevesdwreeves left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:dev-toolsarea:providersprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:elasticsearchprovider:googleGoogle (including GCP) related issuesprovider:oracletype:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@eumiro@potiuk@uranusjr@dwreeves@ephraimbuddy