Skip to content

Refactor: Remove trailing whitespace from strings - #34121

Closed
eumiro wants to merge 3 commits into
apache:mainfrom
eumiro:remove-trailing-whitespace
Closed

Refactor: Remove trailing whitespace from strings#34121
eumiro wants to merge 3 commits into
apache:mainfrom
eumiro:remove-trailing-whitespace

Conversation

@eumiro

@eumiroeumiro commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

No description provided.

uranusjr
uranusjr reviewed Sep 6, 2023
View reviewed changes
Comment threadairflow/providers/cncf/kubernetes/operators/pod.py Outdated
uranusjr
uranusjr reviewed Sep 6, 2023
View reviewed changes
Comment threadairflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py Outdated
uranusjr
uranusjr reviewed Sep 6, 2023
View reviewed changes
Comment threadairflow/secrets/local_filesystem.py Outdated
@eumiro
eumiroforce-pushed the remove-trailing-whitespace branch from 9e071fb to 250b6f0CompareSeptember 15, 2023 03:51
@eumiro
eumiro marked this pull request as ready for review September 15, 2023 03:51
@eumiro
eumiroforce-pushed the remove-trailing-whitespace branch from 250b6f0 to b096262CompareSeptember 15, 2023 14:59
@eladkal

eladkal commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

Needs rebase and resolve conflicts

@eladkal

eladkal commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

@eumiro can you handle it? I'd like to merge this one

@eladkal

eladkal commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

lets see if #34918 fix the build issue

@uranusjr

uranusjr commented Oct 18, 2023

Copy link
Copy Markdown
Member

Tests don’t agree with the change

@github-actions

github-actionsBot commented Dec 3, 2023

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@uranusjruranusjruranusjr approved these changes
@hussein-awalahussein-awalahussein-awala approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@dstandishdstandishAwaiting requested review from dstandish
@kaxilkaxilAwaiting requested review from kaxil
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees

No one assigned

Labels

area:CLIarea:dev-toolsarea:providersarea:Schedulerincluding HA (high availability) schedulerarea:secretsarea:serializationprovider:apache-flinkprovider:apache-kafkaprovider:apache-kylinprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:googleGoogle (including GCP) related issuesstaleStale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eumiro@eladkal@uranusjr@potiuk@hussein-awala