Uh oh!
There was an error while loading. Please reload this page.
correcting wrong time showing in grid view - #34179
Merged
bbovenzi merged 3 commits intoSep 12, 2023
Merged
Conversation
Abhishek-kumar-ISM
requested review from
ashb, bbovenzi, pierrejeambrun and ryanahamilton
as code ownersSeptember 7, 2023 17:31
Abhishek-kumar-ISM
commented
Sep 7, 2023
ContributorAuthor
@potiuk@Taragolis@eladkal@pierrejeambrun@bbovenzi@ryanahamilton@ashb There was some inconsistency in timings shown in grid view as per related issue. |
bbovenzi
approved these changes
Sep 8, 2023
bbovenzi
commented
Sep 8, 2023
Contributor
Looks good. Just run |
Abhishek-kumar-ISM
commented
Sep 8, 2023
ContributorAuthor
@bbovenzi lints passed, Can you pls check
|
ephraimbuddy pushed a commit
that referenced
this pull request
Oct 5, 2023
* correcting wrong time showing in grid view * lint errors resolved * lint errors resolved (cherry picked from commit 8871f95)
99 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #32751
corrected inconsistent times in grid view.
I have kept the code of time on area above bars same as the time of tooltip, so that there would be no inconsistency.
Earlier photos( It can be seen in photo that tooltip date is 6 Sep, but date above bar is 5 Sep ):
Photo after correction
