Uh oh!
There was an error while loading. Please reload this page.
Fixed rows count in the migration script - #34348
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Can we add a test to protect future changes here?
There was a problem hiding this comment.
@ephraimbuddy I've finally found the time to add the test, although it required more work than expected :)
There was a problem hiding this comment.
Nice to have but not required
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Fixed row count for SQLAlchemy 1.4+ * Updated newsfragments * Fixed typo * Added newline * Added test for `check_bad_references` (cherry picked from commit f349fda)
Changes:
.count()method with an already existingget_query_countmethod;Motivation:
While performing the Apache Airflow update from 2.2.3 to 2.7.1 I faced an issue with the migration:
The cause of the error is that SQLAlchemy changed the behavior of the
selectstatement. It has already been addressed in other places usingfunc.count(), so the problematic line looks more like a typo/oversight.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.