Skip to content

Deprecate numeric type python version in PythonVirtualEnvOperator - #34359

Merged
Taragolis merged 10 commits into
apache:mainfrom
starone99:Remove-float-type-python-version-in-PythonVirtualEnvOperator
Sep 16, 2023
Merged

Deprecate numeric type python version in PythonVirtualEnvOperator#34359
Taragolis merged 10 commits into
apache:mainfrom
starone99:Remove-float-type-python-version-in-PythonVirtualEnvOperator

Conversation

@starone99

@starone99starone99 commented Sep 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Deprecate float type python version in PythonVirtualEnvOperator.
If input is 3.10 as float, it is interpreted as python version 3.1.

Also deprecated int type because of consistency.

@BlueHorn07 found the issue.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@starone99
Remove float type python version in PythonVirtualEnvOperator
482b40a
Remove float type python version in PythonVirtualEnvOperator
@boring-cyborg

boring-cyborgBot commented Sep 14, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr

uranusjr commented Sep 14, 2023

Copy link
Copy Markdown
Member

Personally I’d even remove the int case, being able to pass python_version=3 is not particularly useful and can be rewritten pretty trivially.

We should add a news fragment for this.

uranusjr
uranusjr reviewed Sep 14, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
@starone99starone99 changed the title Remove float type python version in PythonVirtualEnvOperatorRemove numeric type python version in PythonVirtualEnvOperatorSep 14, 2023
ephraimbuddy
ephraimbuddy reviewed Sep 14, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
@starone99
change deprecated to removed
7a41e40
change deprecated to removed
Taragolis
Taragolis reviewed Sep 14, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
@starone99
change removal to deprecation
2997931
change removal to deprecation
@starone99starone99 changed the title Remove numeric type python version in PythonVirtualEnvOperatorDeprecate numeric type python version in PythonVirtualEnvOperatorSep 14, 2023
hussein-awala
hussein-awala reviewed Sep 14, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
uranusjr
uranusjr reviewed Sep 15, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
@eladkaleladkal added this to the Airflow 2.7.2 milestone Sep 15, 2023
@starone99
change condition statement
8542931
change condition statement
uranusjr
uranusjr reviewed Sep 15, 2023
View reviewed changes
Comment threadairflow/operators/python.py Outdated
@Taragolis
Taragolis merged commit b23d3f9 into apache:mainSep 16, 2023
@boring-cyborg

boring-cyborgBot commented Sep 16, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@starone99
starone99 deleted the Remove-float-type-python-version-in-PythonVirtualEnvOperator branch September 17, 2023 05:12
@ephraimbuddyephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
@starone99@kyeonghoon-kim
@uranusjr@ephraimbuddy
Deprecate numeric type python version in PythonVirtualEnvOperator (#3…
2324041
…4359)
* Remove float type python version in PythonVirtualEnvOperator
Remove float type python version in PythonVirtualEnvOperator
* Remove int type python version in PythonVirtualEnvOperator
* change deprecated to removed
change deprecated to removed
* change removal to deprecation
change removal to deprecation
* fix typo
fix typo
* fix line too long
fix line too long
* change condition statement
change condition statement
* Use 'is not'
---------
Co-authored-by: kyeonghoon Kim <kyeonghoon.kim@bagelcode.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit b23d3f9)
@ephraimbuddyephraimbuddy mentioned this pull request Oct 9, 2023
Closed
99 tasks
@TaragolisTaragolis mentioned this pull request Nov 2, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@TaragolisTaragolisTaragolis left review comments
@ephraimbuddyephraimbuddyephraimbuddy left review comments
@uranusjruranusjruranusjr approved these changes
@Lee-WLee-WLee-W approved these changes
@hussein-awalahussein-awalahussein-awala approved these changes

Assignees

No one assigned

Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.2

Development

Successfully merging this pull request may close these issues.

9 participants

@starone99@uranusjr@potiuk@Taragolis@ephraimbuddy@Lee-W@hussein-awala@eladkal@kyeonghoon-kim